Closed
Bug 1515296
Opened 6 years ago
Closed 5 years ago
AddonManagerStartup-inlines.h:91:25: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move]
Categories
(Developer Infrastructure :: Source Code Analysis, defect, P2)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox74 fixed)
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(2 files)
/root/firefox-gcc-last/toolkit/mozapps/extensions/AddonManagerStartup-inlines.h: In instantiation of 'mozilla::BaseIterElem<T, IterType>::SelfType mozilla::BaseIterElem<T, IterType>::End() const [with T = mozilla::PropertyIterElem; IterType = mozilla::PropertyIter; mozilla::BaseIterElem<T, IterType>::SelfType = mozilla::PropertyIterElem]':
/root/firefox-gcc-last/toolkit/mozapps/extensions/AddonManagerStartup-inlines.h:36:21: required from 'PropertyType mozilla::BaseIter<T, PropertyType>::end() const [with T = mozilla::PropertyIter; PropertyType = mozilla::PropertyIterElem]'
/root/firefox-gcc-last/toolkit/mozapps/extensions/AddonManagerStartup.cpp:487:39: required from here
/root/firefox-gcc-last/toolkit/mozapps/extensions/AddonManagerStartup-inlines.h:91:25: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move]
91 | return std::move(end);
| ^
|
Assignee | |
Updated•6 years ago
|
Component: Lint and Formatting → Source Code Analysis
|
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → sledru
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/614019a3a5d7
Remove some std::move to fix a gcc warning r=emilio
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70e27e94e164
Follow up - fix the variable r=emilio on a CLOSED TREE
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/614019a3a5d7
https://hg.mozilla.org/mozilla-central/rev/70e27e94e164
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•