Ioana, does your team test with Bitwarden?

I think this may also affect geckoview.

(In reply to Liz Henry (:lizzard) (use needinfo) from comment #1)

Ioana, does your team test with Bitwarden?

We did a bit of testing while the other tools were not working on FxA side. NI Sorina on it.

Tested, with the help of Stefan, on several devices and here are our findings:

• On OnePlus 5T(Android 8.1.0) and on Samsung Galaxy S8(Android 8.0) the "Auto-fill with Bitwarden" prompt was displayed right after we tapped in the email/username field. Selecting the login credentials from the app and then returning to FF was done without issues.

• On Samsung Galaxy Note 8(Android 8.0) the prompt was not displayed, instead, we had a notification from Bitwarden in the notification bar, one of the scenarios presented by the user, but we had no issues when we tapped to autofill.

• On Nexus 6P(Android 8.1.0) the notification was displayed but tapping on it and selecting the credentials didn't work. We got stuck in the Bitwarden app.

We also confirm that the autofill prompt is displayed only once and reloading the page must be performed in order to be visible again.

Tested also on Focus, and the behavior is the same as for Fennec.

[geckoview:fenix:p3] because we should make sure this works in Fenix.

Bitwarden added Fenix, RB, and Rocket to its autofill whitelist on 2019-03-29:

https://github.com/bitwarden/mobile/commit/6088cfe2669d692d60175388aaf59933e07c9be8#diff-743a249a3bb6eca734660644492de094

But the most recent Bitwarden release is version 1.22.0 from 2019-02-04. We should retest this bug after Bitwarden releases a new version:

https://github.com/bitwarden/mobile/releases

(In reply to Chris Peterson [:cpeterson] from comment #6)

But the most recent Bitwarden release is version 1.22.0 from 2019-02-04. We should retest this bug after Bitwarden releases a new version:

https://github.com/bitwarden/mobile/releases

Bitwarden recently released version 2.0.x, which is supposed to include the bug fixes. I filed a PI request asking to retest Fenix/etc: https://jira.mozilla.com/browse/PI-180

Verified the new Bitwarden release (2.0.6 from Jun 16, 2019) on the following apps:
Firefox Preview v. 1.0.1926
Fennec 68.0b14
Focus 8.0.15
Reference browser v. 1.0.1927

Devices used:
Google Pixel 3 (Android 9)
Galaxy Note 8 (Android 9)
HTC 10 (Android 8.0)
Nexus 6P (Android 8.1.0)
Nokia 6 (Android 7.1.1)
Nexus 5 (Android 6.0.1)

Results:
There are still some different issues on different devices, but with no difference between the apps:
On Note 8 and Nexus 6P: One can add new credentials or use the suggested autofill. But, adding a new login or selecting it from the vault, returning to the app won't fill it in. You need to refresh the page and tap it from the auto-fill list. (works fine on HTC 10, S8, Pixel 3).
On a Nokia 6 (Android 7.1.1), there is no auto-fill popup. Tapping the notification banner and selecting a login from the vault will not return to the app, it just opens the Bitwarden vault homepage.
On Nexus 5 (Android 6.0.1), the auto-fill pop-up doesn't appear. But it works fine by tapping the Bitwarden notification and picking a login from the vault.

Everything works fine on the rest of the verified devices.

(In reply to Oana Horvath from comment #8)

On a Nokia 6 (Android 7.1.1), there is no auto-fill popup. Tapping the notification banner and selecting a login from the vault will not return to the app, it just opens the Bitwarden vault homepage.
On Nexus 5 (Android 6.0.1), the auto-fill pop-up doesn't appear. But it works fine by tapping the Bitwarden notification and picking a login from the vault.

Autofill Framework is Android O+. So Oana, is this behavior is same result on both Fenix and Fennec?

(In reply to Makoto Kato [:m_kato] from comment #9)

(In reply to Oana Horvath from comment #8)

On a Nokia 6 (Android 7.1.1), there is no auto-fill popup. Tapping the notification banner and selecting a login from the vault will not return to the app, it just opens the Bitwarden vault homepage.
On Nexus 5 (Android 6.0.1), the auto-fill pop-up doesn't appear. But it works fine by tapping the Bitwarden notification and picking a login from the vault.

Autofill Framework is Android O+. So Oana, is this behavior is same result on both Fenix and Fennec?

Yes, both function the same way, don't automatically return to the browser. But, with one difference: with Fenix, you tap back until you return to the app and then it will fill out the login form. On Fennec, it will not fill it out on return.

(In reply to Oana Horvath from comment #8)

On Note 8 and Nexus 6P: One can add new credentials or use the suggested autofill. But, adding a new login or selecting it from the vault, returning to the app won't fill it in. You need to refresh the page and tap it from the auto-fill list. (works fine on HTC 10, S8, Pixel 3).
On a Nokia 6 (Android 7.1.1), there is no auto-fill popup. Tapping the notification banner and selecting a login from the vault will not return to the app, it just opens the Bitwarden vault homepage.
On Nexus 5 (Android 6.0.1), the auto-fill pop-up doesn't appear. But it works fine by tapping the Bitwarden notification and picking a login from the vault.

Oana, does Bitwarden have these same issues when using Chrome on these devices? I'm wondering whether these are Fennec/Fenix bugs or a Bitwarden or device bugs.

(In reply to Chris Peterson [:cpeterson] from comment #11)

(In reply to Oana Horvath from comment #8)

On Note 8 and Nexus 6P: One can add new credentials or use the suggested autofill. But, adding a new login or selecting it from the vault, returning to the app won't fill it in. You need to refresh the page and tap it from the auto-fill list. (works fine on HTC 10, S8, Pixel 3).
On a Nokia 6 (Android 7.1.1), there is no auto-fill popup. Tapping the notification banner and selecting a login from the vault will not return to the app, it just opens the Bitwarden vault homepage.
On Nexus 5 (Android 6.0.1), the auto-fill pop-up doesn't appear. But it works fine by tapping the Bitwarden notification and picking a login from the vault.

Oana, does Bitwarden have these same issues when using Chrome on these devices? I'm wondering whether these are Fennec/Fenix bugs or a Bitwarden or device bugs.

Yes, Chrome has the same issues with Bitwarden.

(In reply to Oana Horvath from comment #12)

Yes, Chrome has the same issues with Bitwarden.

Thanks for checking. In that case, these remaining issues look like Bitwarden's bugs. I think we can close this bug as WORKSFORME.

The PI request (PI-180) has been resolved.