Closed
Bug 1515579
Opened 6 years ago
Closed 6 years ago
Use absolute paths for compilers, etc.
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Like for other windows platforms. This currently doesn't make a
difference, but will with next change.
Assignee | ||
Comment 2•6 years ago
|
||
In bug 1259382, some workarounds were added to make the build system
alter PATH and not use absolute paths for toolchain programs, because
autoconf and the build system doesn't deal with spaces in those very
well. But later in bug 1290040, we made find_program return Windows
short paths (without spaces), which alleviates the need for those
workarounds.
We still, however, and unfortunately, need to alter PATH to account for
the fact that MSVC DLLs are not necessarily alongside the compiler
executables...
Depends on D15181
Comment 3•6 years ago
|
||
bugherder |
Comment 4•6 years ago
|
||
Backed out for causing bugs: 1516228, 1516090, 1516253.
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=d30b4fd63e1723d205e31251af32ba8930aa9abd
Backout: https://hg.mozilla.org/mozilla-central/rev/d2bc993e14ea1384c2d9b80cca098b48eb19948a
Flags: needinfo?(mh+mozilla)
Updated•6 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•6 years ago
|
status-firefox66:
fixed → ---
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5b112f7e8d9d
Add some mk_export_correct_style to win64-aarch64 mozconfig. r=ted
https://hg.mozilla.org/integration/autoland/rev/fa8e39feef43
Use absolute paths for compilers, etc. r=ted
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5b112f7e8d9d
https://hg.mozilla.org/mozilla-central/rev/fa8e39feef43
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•