Jan de Mooij [:jandem] Assignee
	Description • 6 years ago

A bunch of relatively minor test and code changes to get these tests more green.

	Jan de Mooij [:jandem] Assignee
	Comment 1 • 6 years ago

The code was trying to implement the getOwnPropertyDescriptor trap in terms of
getPropertyDescriptor, by comparing the "holder" object we found to the object
we did the lookup on. This becomes buggy when wrappers like WindowProxy are involved.

The patch removes this check and calls JS_GetOwnPropertyDescriptor instead of
JS_GetPropertyDescriptor.

	Jan de Mooij [:jandem] Assignee
	Comment 2 • 6 years ago

Depends on D15091

	Jan de Mooij [:jandem] Assignee
	Comment 3 • 6 years ago

With same-compartment chrome globals these would end up in the same compartment.
We need to prevent that because the debugger doesn't support it.

Depends on D15092

	Jan de Mooij [:jandem] Assignee
	Comment 4 • 6 years ago

Depends on D15093

	Pulsebot
	Comment 5 • 6 years ago

Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/12f69be06d1e
part 1 - Fix incorrect SandboxProxyHandler::getOwnPropertyDescriptor implementation. r=bzbarsky

	Raul Gurzau (:RaulG)
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/12f69be06d1e

	Pulsebot
	Comment 7 • 6 years ago

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11d454511a09
part 2 - Fix test_bug1042436.xul to create the sandbox in a new compartment because Xray warning state is stored per compartment. r=bholley
https://hg.mozilla.org/integration/autoland/rev/4ebe565c65f9
part 3 - Fix some debugger tests by forcing separate compartments for the debugger and debuggee. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/93ce93d1510d
part 4 - Don't call FixWaiverAfterTransplant if JS_TransplantObject didn't change object identity. r=bholley

	Bogdan Tara[:bogdan_tara | bogdant]
	Comment 8 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/11d454511a09
https://hg.mozilla.org/mozilla-central/rev/4ebe565c65f9
https://hg.mozilla.org/mozilla-central/rev/93ce93d1510d

	Jan de Mooij [:jandem] Assignee
	Comment 9 • 6 years ago

Changes the test to test both freshCompartment: true and freshCompartment: false
sandbox options.

There's one sub test that fails with same-copartment realms, I commented that
and added a weaker test for the same-compartment case.

	Jan de Mooij [:jandem] Assignee
	Comment 10 • 6 years ago

ASan builds caught this.

	Pulsebot
	Comment 11 • 6 years ago

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd13046c9317
part 5 - Fix test_bug771429.xul to work with same-compartment realms. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/d44fc9b89125
part 6 - Fix AddSizeOfTab to reserve number-of-realms instead of number-of-compartments in the realms Vector. r=bzbarsky

	Cosmin Sabou [:CosminS]
	Comment 12 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/dd13046c9317
https://hg.mozilla.org/mozilla-central/rev/d44fc9b89125

	Pulsebot
	Comment 14 • 6 years ago

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d16d586f9cd
part 7 - Null out proxy1 and proxy2 in test_jsterm_autocomplete.html to fix a shutdown leak. r=jlast

	Bogdan Tara[:bogdan_tara | bogdant]
	Comment 15 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5d16d586f9cd

	Jan de Mooij [:jandem] Assignee
	Comment 16 • 6 years ago

Fingers crossed, but I think this is done.