Closed
Bug 1515600
Opened 6 years ago
Closed 6 years ago
Glean: Documentation feedback
Categories
(Toolkit :: Telemetry, enhancement, P2)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
People
(Reporter: sebastian, Assigned: mdroettboom)
References
Details
(Whiteboard: [telemetry:mobilesdk:m4])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
I started to integrate glean into the reference browser and followed the documentation in the android components repository.
* https://github.com/mozilla-mobile/reference-browser/pull/349
* https://github.com/mozilla-mobile/android-components/tree/master/components/service/glean
Overall that worked fine. I took some notes of things where I stumbled a bit:
* The documentation mentions how to add the plugin and build script to the "main build.gradle". In understood this as the build.gradle file in the project root. However I think in this case this should go into the build.gradle of the "app" module (since that's where its in the glean sample app too).
* I had the same issue with metrics.yaml. I didn't know where I need to put it. I guess into the app module too (looking at the sample app).
* I made a copy and paste error when copying the "apply" part into my build.gradle file and setting it up to use the same version as the dependency felt a bit cumbersome. I wonder how we could make that nicer in the future.
* Every app needs some way control telemetry in the UI. It took me a while to find `setMetricsEnabled()`. Maybe it's worth mentioning this in the docs or adding this to the sample code. I wasn't 100% sure if that is the correct toggle and whether this is enough and can be toggled at any time (e.g. the user disables telemetry).
Updated•6 years ago
|
Points: --- → 1
Priority: -- → P2
Whiteboard: [telemetry:mobilesdk:m4]
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mdroettboom
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
I separated the issue about version matching to its own bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1520499
Assignee | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•