[flake8] Remove ability to specify subdir configs
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P2)
Tracking
(firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(3 files)
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Flake8 3.7.1 with the prerequisite feature was released yesterday.
Assignee | ||
Comment 2•6 years ago
|
||
Somehow we have two copies of the flake8 linter implementation:
- tools/lint/python/__init__.py
- tools/lint/python/flake8.py
I'm not really sure how this happened, but the latter is the one that we use,
so let's remove the former. It wasn't really affecting anything, though could
have caused confusion to people looking to modify the lint integration.
Assignee | ||
Comment 3•6 years ago
|
||
This bumps flake8 to version 3.7.3.
This also ignores the new lint rules that were added in the new versions.
These rules are de-marked via comment so we know that they should be enabled at
some point (as opposed to the other rules that are (presumably) ignored
intentionally.
Depends on D18352
Assignee | ||
Comment 4•6 years ago
|
||
This removes all .flake8 files except for the one at the root of the repo.
Instead we use the new 'per-file-ignores' config introduced in 3.7. To ignore
specific errors in a subdirectory, add a line like this to the root .flake8:
[per-file-ignores]
path/to/subdir/*: E100, F200, ...
The reasons for this change are:
- Unblock flake8 blacklist (bug 1367092).
- Simplify configuration and code.
- Encourage more consistent styling.
- Improve performance.
- Greater editor consistency.
Depends on D18353
Assignee | ||
Updated•6 years ago
|
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ba9e0f7f49a3
https://hg.mozilla.org/mozilla-central/rev/3c7c50fba283
https://hg.mozilla.org/mozilla-central/rev/f96c1460ffc0
Updated•2 years ago
|
Description
•