Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Description • 6 years ago

Per bug #1513284, minidump-stackwalker in Socorro is using an old breakpad client and it needs to be updated.

https://bugzilla.mozilla.org/show_bug.cgi?id=1513284#c15

> (In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #13)
> > Socorro is using breakpad rev a61afe7a3e865f1da7ff7185184fe23977c2adca.
> > Maybe we need to update it?
> 
> Yeah, it's pretty old and it's missing the changes to understand
> AArch64 minidumps using Microsoft format. Our checkout in 
> mozilla-central is at version 1459e5df74dd03b7d3d473e6d271413d7aa98a88
> plus some of our patches. That should be enough and as Mike mentioned
> the one in tooltool should also be good enough.

This bug covers updating the breakpad client.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 1 • 6 years ago

Hrm.... The depot_tools don't work in Python 3, so we can't build the breakpad client in the app Docker image we've got. Seems like if we have a breakpad client already, then building stackwalker works--that's how deploys have been working so far.

I think Ted said when he's debugging breakpad/stackwalker issues, he builds it locally. That works for me, too. However, if someone pops in for whom that doesn't work, then we might want to set up a "breakpad/stackwalk-debug" image.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 2 • 6 years ago

Rrr... I feel silly--I can't build stackwalker outside the container and then run it inside the container because I've got different versions of the libs.

I'm going to spend some time tweaking the scripts so we can build and run everything inside the container.

	[github robot]
	Comment 4 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/7ee852e3d530cc95a2bdab91a6c00187a6bdf882
bug 1515805: fix breakpad client building in image; add scripts

Building the breakpad client requires using depot_tools which only work with
Python 2. This fixes the build-breakpad.sh script so it makes sure depot_tools
are using Python 2 in the Docker container.

This adds a scripts/run_mdsw.sh script which runs minidump-stackwalker just
like we do in the processor, but outside of the processor. This makes it
a lot easier to debug issues with minidump-stackwalker.

https://github.com/mozilla-services/socorro/commit/b970b6c97c908e76a990f94561d7d62bdd893408
Merge pull request #4754 from willkg/1515805-breakpad

bug 1515805: fix breakpad client building in image; add scripts

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 5 • 6 years ago

I've got this version of breakpad client working with minidump-stackwalker. I have taskcluster permissions to run the taskcluster task.

Next steps:

1. run the taskcluster task which will update the binary to 1459e5d
2. land the changes in the master branch
3. that'll trigger a stage deploy with the new binary
4. test everything out on stage
5. do a prod deploy

I think I can do all that on Monday.