Closed
Bug 1515892
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 14626 - Move 'contain: size' handling for replaced content
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14626 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/14626
Details from upstream follow.
Fredrik Söderquist <fs@opera.com> wrote:
> Move 'contain: size' handling for replaced content
>
> For Legacy layout, hoist the check for size containment out to
> ComputeIntrinsicSizingInfoForReplacedContent, since this is the "real"
> entrypoint.
> For NG, put the check in NGLayoutInputNode::IntrinsicSize.
>
> This also makes ComputeIntrinsicSizingInfo slightly more focused on
> computing the intrinsic dimensions, and avoids calling it at all if
> the box is subject to size containment.
>
> Bug: 917018
> Change-Id: I0e3fdc48e9c5a104cadaa253cb7cef23fdc42ece
>
> Reviewed-on: https://chromium-review.googlesource.com/1386849
> WPT-Export-Revision: 07085765f1e14c6b77a91f4f6c1ea95d9ad92794
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2ec3bfd263ab4ac9663380d6c74d9d795e52555
Assignee | ||
Comment 4•6 years ago
|
||
Ran 2 tests
FAIL : 2
New tests that have failures or other problems:
/css/css-contain/contain-size-replaced-001.html: FAIL
/css/css-contain/contain-size-replaced-002.html: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92b9d4b466ce
[wpt PR 14626] - Move 'contain: size' handling for replaced content, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3e73a739387
[wpt PR 14626] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8af325c4532
[wpt PR 14626] - Move 'contain: size' handling for replaced content, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/815e35021909
[wpt PR 14626] - Update wpt metadata, a=testonly
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c8af325c4532
https://hg.mozilla.org/mozilla-central/rev/815e35021909
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•