Geoff Lankow (:darktrojan) Assignee
	Description • 6 years ago

We should be able to use the push-to-release task to also upload Lightning and GData Provider to the archive. I guess this might require creating a Lightning artifact, which is easy enough, and there is already a GData artifact.

	Rob Lemley [:rjl]
	Comment 3 • 5 years ago

This just gets the gdata-provider.xpi for en-US up in the FTP area to
avoid passing out the URL to the Taskcluster artifact in the release
notes.

The try job I ran did the right thing, the result can be seen at
http://ftp.stage.mozaws.net/pub/thunderbird/nightly/latest-try-comm-central/

The filename can be changed, I've set it to thunderbird-70.0a1.gdata-provider.en-US.xpi

I am fast tracking at least this piece of this bug so it gets into 68.0.

	Geoff Lankow (:darktrojan) Assignee
	Comment 4 • 5 years ago

Comment on attachment 9080968 [details] [diff] [review]
gdata-provider-to-ftp.patch

Review of attachment 9080968 [details] [diff] [review]:
-----------------------------------------------------------------

The idea's right, but I have too many questions.

::: taskcluster/comm_taskgraph/manifests/thunderbird_candidates.yml
@@ +330,5 @@
> +        description: "Google data provider XPI (en-US only)"
> +        all_locales: false  # Uses default_locale only
> +        from:
> +            - build
> +        pretty_name: thunderbird-${version}.gdata-provider.${locale}.xpi

I think this should be gdata-provider-${version}.${locale}.xpi.

@@ +331,5 @@
> +        all_locales: false  # Uses default_locale only
> +        from:
> +            - build
> +        pretty_name: thunderbird-${version}.gdata-provider.${locale}.xpi
> +        checksums_path: ${path_platform}/xpi/${locale}.xpi

That's surely not right … ?

@@ +333,5 @@
> +            - build
> +        pretty_name: thunderbird-${version}.gdata-provider.${locale}.xpi
> +        checksums_path: ${path_platform}/xpi/${locale}.xpi
> +        only_for_platforms:
> +            - linux64-shippable

Do we not want the other platforms too? Sure, they're all the same, but it seems a bit odd.

::: taskcluster/comm_taskgraph/manifests/thunderbird_nightly.yml
@@ +397,5 @@
> +        all_locales: false  # Uses default_locale only
> +        from:
> +            - build
> +        pretty_name: thunderbird-${version}.gdata-provider.${locale}.xpi
> +        checksums_path: thunderbird-${version}.gdata-provider.${locale}.xpi

Again with the name.

@@ +403,5 @@
> +            - linux64-shippable
> +        destinations:
> +            - ${year}/${month}/${upload_date}-${branch}
> +            - latest-${branch}
> +            - latest-${branch}-l10n

I'm not sure it's useful in the latest-comm-central-l10n directory.

	Rob Lemley [:rjl]
	Comment 5 • 5 years ago

Most review comments addressed.

- Use "${locale}" in original filename rather than en-US (tested, does work)
- Sticking with only building for linux64 platform to make things easier
  for anyone looking to download from FTP and whoever mmay upload to ATN.
- Dropped the "thunderbird-${version}" from pretty-names
- Keeping the destination directories the same for both nightly and
  release builds, including the latest-${branch}-l10n one. The other
  en-US specific files go there, this might as well too.

No try job run to verify, trees currently closed.

	Jorg K (CEST = GMT+2)
	Comment 9 • 5 years ago

Comment on attachment 9081687 [details] [diff] [review]
gdata-provider-to-ftp.patch

I did it for you in case we're building another beta soonish, so it doesn't get forgotten.

	Rob Lemley [:rjl]
	Comment 19 • 5 years ago

Comment on attachment 9083860 [details] [diff] [review]
1516816-upload-xpis-1.diff

Review of attachment 9083860 [details] [diff] [review]:
-----------------------------------------------------------------

Ahh I see, took a minute to realize that comment 18 was a link to your try build. :) Bug 1569539 already landed which is the breaking change mentioned in comment 16.