Closed
Bug 1517057
Opened 6 years ago
Closed 6 years ago
nsScriptSecurityManager::GetChannelResultPrincipal() always mints a new principal
Categories
(Firefox :: Protections UI, enhancement)
Firefox
Protections UI
Tracking
()
RESOLVED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files)
See <https://searchfox.org/mozilla-central/rev/bcc0fe1081dc4f84fc5fdfebe0d2de8c075a4e2c/toolkit/components/antitracking/AntiTrackingCommon.cpp#1024>.
Minting a new principal can be expensive, see this profile for example: https://perfht.ml/2BPN3BT
This is actually completely unnecessary for us, since we can just use the URI + origin attributes without combining them into a new codebase principal.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D15547
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/23a0332b18a1
Part 1: Remove support for the unused URI_FORBIDS_COOKIE_ACCESS protocol flag; r=baku
https://hg.mozilla.org/integration/autoland/rev/1da34ff3bc95
Part 2: Avoid minting a new codebase principal in the channel-based version of AntiTrackingCommon::IsFirstPartyStorageAccessGrantedFor() in the common case to make things faster; r=baku
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/23a0332b18a1
https://hg.mozilla.org/mozilla-central/rev/1da34ff3bc95
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Updated•6 years ago
|
Assignee: nobody → ehsan
You need to log in
before you can comment on or make changes to this bug.
Description
•