Closed
Bug 1517442
Opened 6 years ago
Closed 6 years ago
"raise_for_port" should not use DEFAULT_STARTUP_TIMEOUT but self.startup_timeout if timeout is None
Categories
(Remote Protocol :: Marionette, defect, P3)
Remote Protocol
Marionette
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: whimboo, Assigned: agboolaolamide9, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=py])
User Story
Please read the following document in how to get started: https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The startup timeout can be customized via an command line argument, and gets set in Marionette client here: https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/testing/marionette/client/marionette_driver/marionette.py#624-627 Later `raise_for_port` doesn't care about it, and simply uses the default value instead: https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/testing/marionette/client/marionette_driver/marionette.py#700-701 Lets change that so the custom value is used.
Reporter | ||
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•6 years ago
|
||
Hi @whimboo, I'm new to open source and would like to work on this issue
Reporter | ||
Comment 2•6 years ago
|
||
Hello Agboola. Feel welcome to our community! I'm looking forward to work with you.
To get started please check the link in the user story above. It contains all the information to get you started. Let me know if there is something unclear. You can ask here, or better connect to our IRC channel (all described in the documentation).
Once the first version of the patch has been uploaded I will mark the bug as assigned to you.
Assignee | ||
Comment 3•6 years ago
|
||
Change raise_for_port from self.DEFAULT_STARTUP_TIMEOUT to self.startup_timeout if timeout is None
Updated•6 years ago
|
Attachment #9036732 -
Attachment description: Bug 1517442 - Change raise_for_port to use self.startup_timeout if timeout is None → Bug 1517442 - Use current instead of default startup time in raise_for_port
Updated•6 years ago
|
Attachment #9036732 -
Attachment description: Bug 1517442 - Use current instead of default startup time in raise_for_port → Bug 1517442 - [marionette] Use current instead of default startup time in raise_for_port
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → agboolaolamide9
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0e6b3cbbd16 [marionette] Use current instead of default startup time in raise_for_port r=whimboo
Comment 5•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•