Closed Bug 1517493 Opened 6 years ago Closed 6 years ago

Migrate pageInfo.dtd to Fluent

Categories

(Firefox :: General, defect, P3)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: jaws, Assigned: nautilus, Mentored)

References

(Depends on 1 open bug, Blocks 2 open bugs, Regressed 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1517493 - migrated pageInfo.dtd and pageInfo.properties to pageInfo.ftl
(deleted), text/x-phabricator-request
Details
pageInfo.dtd[1] should be migrated to Fluent. The new Fluent file should be created at browser\locales\en-US\browser\pageInfo.ftl A migration file should also be created at python\l10n\fluent_migrations The pageInfo.dtd includes a width and height that define the width and height of the subsequent dialog. These are setting the width and height attributes on the dialog. Due to the asynchronous nature of Fluent, these two values will need to set the style attribute instead. Please migrate the width and height values to a style attribute value as was done in [2]. [3] is an example migration script for converting from a width attribute to a style attribute. [1] https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/pageInfo.dtd [2] https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/locales/en-US/browser/preferences/applicationManager.ftl#7 [3] https://hg.mozilla.org/integration/autoland/diff/ab889ec68ba2/python/l10n/fluent_migrations/bug_1451992_preferences_colors.py#l1.32
Priority: -- → P3
Assignee: nobody → freychr3
Status: NEW → ASSIGNED

...system. Updated the function "async _updateSiteDataInfo()" in browser/base/content/pageinfo/security.js to use Fluent localization strings migrated from browser/locales/en-US/chrome/browser/pageInfo.properties into pageInfo.ftl. This fixed an issue where the amount of data and cookies the website stored on my computer would always be listed as "Unknown" because the defualt Fluent strings loaded into the html would always overwrite the original set by security.js.

Attachment #9037447 - Attachment description: Bug 1517493 - Wrote bug_1517493_pageInfo.py to migrate pageInfo.dtd and some strings in pageInfo.properties to browser/locales/en-US/browser/pageInfo.ftl. Edited pageInfo.xul to load the new strings in pageInfo.ftl using the Fluent localization... → Bug 1517493
Attachment #9037447 - Attachment description: Bug 1517493 → Bug 1517493 - Migrate pageInfo.dtd to Fluent
Attachment #9039357 - Attachment is obsolete: true
Attachment #9037447 - Attachment description: Bug 1517493 - Migrate pageInfo.dtd to Fluent → Bug 1517493 - Translating most string from pageInfo.properties and making pageInfo.js and security.js use Fluent, r?jaws,mconley
Attachment #9037447 - Attachment description: Bug 1517493 - Translating most string from pageInfo.properties and making pageInfo.js and security.js use Fluent, r?jaws,mconley → Bug 1517493 Migrating pageInfo to Fluent
Depends on: 1523122
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/cfb1a7fbbfa7 Migrating pageInfo to Fluent r=jaws,flod

Backed out changeset cfb1a7fbbfa7 (Bug 1517493) for bc failures in browser/base/content/test/static/browser_all_files_referenced.js

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=229079648

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229079648&repo=autoland&lineNumber=1353

12:27:46 INFO - indirectly whitelisted file: chrome://passwordmgr/content/recipes.json used from resource://gre/greprefs.js
12:27:46 INFO - indirectly whitelisted file: resource://formautofill/FormAutofillSync.jsm used from resource://services-sync/service.js
12:27:46 INFO - indirectly whitelisted file: chrome://global/locale/AccessFu.properties used from resource://gre/modules/accessibility/Utils.jsm
12:27:46 INFO - indirectly whitelisted file: resource://services-sync/bookmark_repair.js used from resource://services-sync/collection_repair.js
12:27:46 INFO - indirectly whitelisted file: resource://services-sync/doctor.js used from resource://services-sync/bookmark_repair.js,resource://services-sync/stages/enginesync.js
12:27:46 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Traversal.jsm used from resource://gre/modules/accessibility/ContentControl.jsm
12:27:46 INFO - Buffered messages finished
12:27:46 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected 0
12:27:46 INFO - Stack trace:
12:27:46 INFO - chrome://mochikit/content/browser-test.js:test_is:1315
12:27:46 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:786
12:27:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
12:27:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1134
12:27:46 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
12:27:46 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
12:27:46 INFO - Not taking screenshot here: see the one that was previously logged
12:27:46 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/locale/pageInfo.properties -
12:27:46 INFO - Stack trace:
12:27:46 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
12:27:46 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:790
12:27:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
12:27:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1134
12:27:46 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
12:27:46 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
12:27:46 INFO - ignored unused whitelist entry: resource://app/blocklist.xml
12:27:46 INFO - ignored unused whitelist entry: resource://gre/gmp-clearkey/0.1/manifest.json
12:27:46 INFO - ignored unused whitelist entry: resource://gre/res/test.properties
12:27:46 INFO - missing file: resource:///modules/AboutDebuggingNewRegistration.jsm
12:27:46 INFO - missing file: resource://gre/components/nsAsyncShutdown.js
12:27:46 INFO - missing file: resource://gre/modules/commonjs/toolkit/loader.js

Flags: needinfo?(freychr3)
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c2cfcb1247ec Backed out changeset cfb1a7fbbfa7 for bc failures in browser/base/content/test/static/browser_all_files_referenced.js
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d28d0498bd7b Migrating pageInfo to Fluent r=jaws,flod,Gijs

There are also failures at: browser/base/content/test/pageinfo/browser_pageinfo_firstPartyIsolation.js

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229609492&repo=autoland&lineNumber=2086

Attachment #9037447 - Attachment description: Bug 1517493 Migrating pageInfo to Fluent → Bug 1517493 - Wrote bug_1517493_pageInfo.py to migrate pageInfo.dtd and some strings in pageInfo.properties to browser/locales/en-US/browser/pageInfo.ftl.
Attachment #9037447 - Attachment description: Bug 1517493 - Wrote bug_1517493_pageInfo.py to migrate pageInfo.dtd and some strings in pageInfo.properties to browser/locales/en-US/browser/pageInfo.ftl. → Bug 1517493 Migrating pageInfo to Fluent
Attachment #9037447 - Attachment description: Bug 1517493 Migrating pageInfo to Fluent → Bug 1517493 - Wrote bug_1517493_pageInfo.py to migrate pageInfo.dtd and some strings in pageInfo.properties to browser/locales/en-US/browser/pageInfo.ftl.
Attachment #9037447 - Attachment description: Bug 1517493 - Wrote bug_1517493_pageInfo.py to migrate pageInfo.dtd and some strings in pageInfo.properties to browser/locales/en-US/browser/pageInfo.ftl. → Bug 1517493 - migrated pageInfo.dtd and pageInfo.properties to pageInfo.ftl
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/03aece6cda47 migrated pageInfo.dtd and pageInfo.properties to pageInfo.ftl r=jaws,flod,Gijs

https://hg.mozilla.org/mozilla-central/rev/03aece6cda47

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Flags: needinfo?(freychr3)
Depends on: 1530073
Regressions: 1554399
Regressions: 1567624
Regressions: 1596767
Regressions: 1632798
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: