[de-xbl] Migrate results-message to custom element.
Categories
(Thunderbird :: Mail Window Front End, task)
Tracking
(Not tracked)
People
(Reporter: arshad, Assigned: arshad)
References
Details
Attachments
(1 file, 6 obsolete files)
(deleted),
patch
|
arshad
:
review+
|
Details | Diff | Splinter Review |
Binding Link - https://searchfox.org/comm-central/source/mail/base/content/glodaFacetBindings.xml#1166
Assignee | ||
Comment 1•6 years ago
|
||
Hey Magnus, This patch appears to successfully render results but somehow it messes up the facet visualization. I get `this.mm is null` where this.mm is asssigned docshell.messageManager. Could you please take a look at this and let me know which part of the patch is messing up things ?
Assignee | ||
Updated•6 years ago
|
Comment 2•6 years ago
|
||
The this.mm problem seems to be because of some bug in objectTreeAsString
If I temporarily remove that, I get the real problem
rules is undefined glodaFacetVis.js:176
render chrome://messenger/content/glodaFacetVis.js:176
build chrome://messenger/content/glodaFacetVis.js:28
buildFunc chrome://messenger/content/glodaFacet.js:53
facetingCompleted chrome://messenger/content/glodaFacetView.js:585
_drive resource:///modules/gloda/facet.js:107
FacetDriver_go resource:///modules/gloda/facet.js:80
build chrome://messenger/content/glodaFacetView.js:530
initialBuild chrome://messenger/content/glodaFacetView.js:493
onQueryCompleted chrome://messenger/content/glodaFacetView.js:963
GlodaMsgSearcher_onQueryCompleted resource:///modules/gloda/msg_search.js:339
gloda_coll_onQueryCompleted resource:///modules/gloda/collection.js:626
onQueryCompleted resource:///modules/gloda/datastore.js:149
gloda_coll_onQueryCompleted resource:///modules/gloda/collection.js:626
onQueryCompleted resource:///modules/gloda/datastore.js:149
gloda_coll_onQueryCompleted resource:///modules/gloda/collection.js:626
onQueryCompleted resource:///modules/gloda/datastore.js:149
gloda_coll_onQueryCompleted resource:///modules/gloda/collection.js:626
onQueryCompleted resource:///modules/gloda/datastore.js:149
gloda_ds_qfq_handleCompletion resource:///modules/gloda/datastore.js:390
Comment 3•6 years ago
|
||
Unbitrotted and with the temporary uncommenting. You should be able to get on with this bug now
Comment 5•6 years ago
|
||
Now with the lodaFacetBindings.xml file removed
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
Comment on attachment 9045675 [details] [diff] [review] results-message.patch Review of attachment 9045675 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin with some nits fixed Also run it past try before setting checkin-needed ::: mail/base/content/glodaFacet.js @@ +64,5 @@ > } > } > > +/** > + * MozResultsMessage shows up the search results for the string entered in gloda-searchbox. remove the "up" @@ +223,2 @@ > customElements.define("facet-date", MozFacetDate); > +customElements.define("facet-results-message", MozResultsMessage); Please make the class name MozFacetResultsMessage
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
(In reply to Arshad Khan [:arshad] from comment #9)
Created attachment 9045901 [details] [diff] [review]
results-message.patch
I need to rebase the patch, but I am not sure whether trunk is failing or not.
Assignee | ||
Comment 14•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 16•6 years ago
|
||
Comment 17•6 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f87c5afa28b8
Migrate results-message binding to custom element. r=mkmelin
Updated•6 years ago
|
Updated•5 years ago
|
Description
•