Leaks in WPT tests in /html/semantics/forms/form-submission-0/
Categories
(Core :: Storage: localStorage & sessionStorage, defect, P2)
Tracking
()
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
(Keywords: memory-leak, Whiteboard: [MemShrink:P2])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
|
||
Updated•6 years ago
|
|
Assignee | |
Comment 1•6 years ago
|
||
In the XPCOM leak checker, this directory leaks 3 windows and 3 documents, among other things.
|
|
Assignee | |
Comment 2•6 years ago
|
||
I get two window/documents leaks with this test:
./mach wpt html/semantics/forms/form-submission-0/submit-file.sub.html
I didn't find another test that leaks, but maybe there is one. That's at least a start.
|
|
Assignee | |
Comment 3•6 years ago
|
||
There's a Blob that is leaking things. I'll see if I can figure out what is holding that alive tomorrow.
|
|
Assignee | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 4•6 years ago
|
||
I was able to use DMD heap scan mode to figure out what was going wrong. DataTransferItemList::Add needs to use nsVariantCC instead of nsVariant. I should probably make that less of a footgun somehow.
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
||
Updated•6 years ago
|
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 10•6 years ago
|
||
Comment on attachment 9035496 [details]
Bug 1517577 - DataTransferItemList::Add should use nsVariantCC.
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 906420
User impact if declined: Bad leaks, but it isn't clear if anybody is actually hitting this in the wild. This is an old bug.
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): This just makes an object be cycle collected instead of not cycle collected.
String changes made/needed: none
|
|
||
Comment 11•6 years ago
|
||
Comment on attachment 9035496 [details]
Bug 1517577 - DataTransferItemList::Add should use nsVariantCC.
[Triage Comment]
Low risk fix for a possibly-bad leak. Approved for 65.0b11.
|
|
||
Comment 12•6 years ago
|
||
| bugherder uplift | ||
Description
•