Add enable toggle and cache/endpoint info to DiscoveryStream devtools
Categories
(Firefox :: New Tab Page, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: k88hudson, Assigned: k88hudson)
References
Details
Attachments
(2 files)
Screen Shot 2019-01-08 at 12.00.33 PM.png
In this bug we'll add some basic devtools for turning DiscoveryStream on/off and looking at cache info.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 1•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/9220cb8e28d2f24906510b67c71b3ad40356a1c2 Bug 1517596 - Add basic DiscoveryStream devtools
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 2•6 years ago
|
||
Can you verify devtools are working as expected?
Steps are:
- Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true in about:config
- Visit about:newtab#devtools-ds. Ensure you see devtools
- Try turning the new tab experiment off/on via the "enabled" checkbox, you should existing and newly opened tabs show the default experience / the experiment according to this setting.
|
||
Comment 3•6 years ago
|
||
Sure, will do as soon as build is ready tomorrow.
|
||
Comment 4•6 years ago
|
||
|
|
||
Comment 5•6 years ago
|
||
As of step3 :
Can you please clarify :
What does "existing and newly opened tabs show the default experience / the experiment according to this setting." mean?
Tested on both Mac and Windows (Version : 66.0a1 (2019-01-08))
MAC OS :
I see the difference for enabled vs disabled :
Enabled :
--> On New Tab Standard experience is missing, and seeing as in attachment, or is the new tab view as expected?
--> Rest works fine : Search Adding articles via Pocket tile
Disabled :
Standard experience and works as expected
WINDOWS :
After config setup , "about:newtab#devtools-ds" page has
- Text misalignment.
- Not able to turn on/off "enabled" switch. (Nothing happens)
|
|
Assignee | |
Comment 6•6 years ago
|
||
The screenshot you posted for enabled state is expected for now, as the design hasn't been fully implemented
For windows, I'm interested that you're not able to turn the on/off enabled switch – that definitely doesn't sound right!
|
|
||
Comment 7•6 years ago
|
||
(In reply to Brahmini Nagabandi from comment #5)
Created attachment 9035127 [details]
Screen Shot 2019-01-08 at 12.00.33 PM.pngAs of step3 :
Can you please clarify :
What does "existing and newly opened tabs show the default experience / the experiment according to this setting." mean?Tested on both Mac and Windows (Version : 66.0a1 (2019-01-08))
MAC OS :
I see the difference for enabled vs disabled :
Enabled :
--> On New Tab Standard experience is missing, and seeing as in attachment, or is the new tab view as expected?
--> Rest works fine : Search Adding articles via Pocket tileDisabled :
Standard experience and works as expectedWINDOWS :
After config setup , "about:newtab#devtools-ds" page has
- Text misalignment.
- Not able to turn on/off "enabled" switch. (Nothing happens)
|
|
Assignee | |
Comment 8•6 years ago
|
||
After testing on windows on latest nightly, it seems that the enabled switch is working. Can you confirm this is still an issue, if so, maybe we can try to verify over Vidyo?
|
|
||
Comment 9•6 years ago
|
||
|
|
Assignee | |
Comment 10•6 years ago
|
||
This should be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1520259
|
|
||
Comment 11•6 years ago
|
||
Will check when the build is ready.
|
|
||
Comment 12•6 years ago
|
||
Test Results:
Verified on :
FF Nightly Version - 66.0a1 (2019-01-17)
OS - Mac / Windows 10 Pro N
Looks good to me.
|
|
||
Updated•6 years ago
|
|
||
Updated•5 years ago
|
Description
•