Closed
Bug 1518038
Opened 6 years ago
Closed 6 years ago
Add nsIThread.hasPendingHighPriorityEvents
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
I would expect we'll need this in many places when improving paint scheduling.
Unfortunately our thread implementation is super complicated atm and has some odd abstractions which are mostly unused - so the patch is way larger than it needs to be. Patch coming.
Assignee | ||
Comment 1•6 years ago
|
||
This adds also nsThreadManager::MainThreadHasPendingHighPriorityEvents().
I tested this stuff locally by adding
nsThreadManager::MainThreadHasPendingHighPriorityEvents() calls to ContentSink and we do have pending high prio events occasionally during parsing.
Lots of boilerplate code to check !mHighQueue->IsEmpty(aProofOfLock);
Attachment #9034625 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9034625 [details] [diff] [review]
haspendinghighprioevents.diff
Review of attachment 9034625 [details] [diff] [review]:
-----------------------------------------------------------------
Bug 1514011 comment 4 says that we might not need this?
Attachment #9034625 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 4•6 years ago
|
||
In that bug, but I actually need this elsewhere.
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9fcbe28afda
Add nsIThread.hasPendingHighPriorityEvents, r=froydnj
Comment 6•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•