Closed Bug 1518197 Opened 6 years ago Closed 6 years ago

Cannot paste something in search bar with context menu or linux middle-click

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 66
Iteration:
66.3 - Jan 7 - 20
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- unaffected
firefox66 + verified

People

(Reporter: calixte, Assigned: rrosario)

References

Details

(Keywords: github-merged, regression)

Attachments

(2 files)

I'm used to paste some stuff in newtab searchbar in using middle button. But it doesn't work anymore.
With the help of mozregression, I found:

6:34.09 INFO: Last good revision: 48b2aa8dc68fa2c5a5edef5fd171267361b4646a
6:34.09 INFO: First bad revision: 5990f24b16efd56b80acc265ef70548481f47784
6:34.09 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=48b2aa8dc68fa2c5a5edef5fd171267361b4646a&tochange=5990f24b16efd56b80acc265ef70548481f47784

which indicates that patch for bug 1516272 could be the one introducing this regression.

:Mardak, could you investigate please ?

Flags: needinfo?(edilee)

This is most likely from the search handoff feature where in-content search just redirects to the address bar.

What exactly is the expected functionality? Does it just paste the contents into the box or does it also do a search at the same time?

If the former, maybe we should somehow handoff on paste events too?

In the mean time, a workaround is to set browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar=false

Blocks: 1508388
No longer blocks: 1516272
Flags: needinfo?(edilee) → needinfo?(cdenizet)

As far as I know, it just pastes the contents from the clipboard.

Flags: needinfo?(cdenizet)

Ah, well middle-click won't quite work as it's implemented right now as it's just a div that looks like a text box. If we want to support this functionality, it could probably be done with a transparent input/text box that can accept these types of events.

Otherwise, I suppose users would learn to middle-click directly into the address bar instead of the in-content one… ?

Summary: Cannot paste something in search bar in clicking on the mouse wheel under linux → Cannot paste something in search bar with context menu or linux middle-click

[Tracking Requested - why for this release]:
Recent regression in nightly

Assignee: nobody → rrosario
Iteration: --- → 66.3 - Jan 7 - 20
Priority: -- → P1
Attached file GitHub Pull Request (deleted) —
Blocks: 1519303
Whiteboard: [github merged]
Keywords: github-merged
Whiteboard: [github merged]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

I have verified that the issue is no longer reproducible on the latest Nightly 66.0a1 (Build ID 20190116093310) on Windows 10 x64, Mac 10.13, and Arch Linux 4.14.3.

Status: RESOLVED → VERIFIED
Blocks: 1520697
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: