Closed
Bug 1518220
Opened 6 years ago
Closed 6 years ago
Remove use of document.l10n.formatValues in aboutDialog.js
Categories
(Firefox :: General, enhancement, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jaws, Assigned: chengy12, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
text/x-phabricator-request
|
Details |
aboutDialog.js uses formatValues to append the architecture of the build to the version number. We should be using Fluent arguments for this.
See errant code at https://searchfox.org/mozilla-central/rev/76fe4bb385348d3f45bbebcf69ba8c7283dfcec7/browser/base/content/aboutDialog.js#57
aboutDialog.ftl is located at https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/aboutDialog.ftl
You will need to use document.l10n.setAttributes to set the ID and attributes for the element. The definition of setAttributes is at https://searchfox.org/mozilla-central/rev/76fe4bb385348d3f45bbebcf69ba8c7283dfcec7/intl/l10n/DOMLocalization.jsm#474
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Reporter | |
Updated•6 years ago
|
Assignee: nobody → chengy12
Status: NEW → ASSIGNED
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D16716
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9037086 -
Attachment description: Bug 1518220 - Replace the usage of formatValues with Flunt arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws
|
|
||
Updated•6 years ago
|
Attachment #9037086 -
Attachment is obsolete: true
|
|
||
Updated•6 years ago
|
Attachment #9036973 -
Attachment is obsolete: true
|
|
||
Updated•6 years ago
|
Attachment #9037104 -
Attachment description: Bug 1518220 - Replace the usage of formatValues with Flunt arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws
|
|
||
Updated•6 years ago
|
Attachment #9037104 -
Attachment description: Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Flunt arguments, r?Gijs,jaws
|
|
||
Updated•6 years ago
|
Attachment #9037104 -
Attachment description: Bug 1518220 - Replace the usage of formatValues with Flunt arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws
|
|
||
Updated•6 years ago
|
Attachment #9037104 -
Attachment description: Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs!,jaws!
|
|
||
Updated•6 years ago
|
Attachment #9037104 -
Attachment description: Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs!,jaws! → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a3cb2c2431d
Replace the usage of formatValues with Fluent arguments, r=jaws,flod
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•