Closed Bug 1518364 Opened 6 years ago Closed 6 years ago

Ensure all the services and libraries in monorepo run the same Node version

Categories

(Taskcluster :: Services, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: owlish, Assigned: owlish)

References

Details

Options:

  1. Write a metatest
  2. Research yarn's workspaces capabilities - maybe there's a way of ensuring the same engine version
  3. Use any other device (.taskcluster.yml ?) to prevent different services running on different Node versions

What happens now if a engines property in some package.json is wrong?

Another thing that maybe we can consider is to actually make all of the services on package? That would require them using the same versions of libraries but I think that's the only thing stopping us. The rest of package.json is kinda useless for them afaict.

I don't think it matters a whole lot if engines is wrong. It would just be nice if they were the same.

Let's hold off on that for a bit. I think when we get more stuff in the monorepo, and less not in it, and are only deploying to GKE, we can think about making the whole thing one big JS project.

Fresh development: Heroku doesn't read engine from individual package.json, so for now I have engine in the monorepo root package.json only.

Also, when running tests locally, individual package.json overrides the root one. I haven't experimented with GKE deployments yet. So for now makes sense all-round to just keep engine in one place - in the root package.json

Status: NEW → UNCONFIRMED
Ever confirmed: false

I saw Dustin added a metatest asserting the Node version is the same in package.json and .taskcluster.yml, which seems to have sealed this bug. Appears to be resolved now? I am closing it for now

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

I didn't mean to steal your bug, but if that's what was necessary, great!

Oh I didn't mean that at all! The most important thing - it needed to be done, and it's awesome you did it! I just wasn't sure if the bug was resolved or not

Component: Platform and Services → Services
You need to log in before you can comment on or make changes to this bug.