Ensure all the services and libraries in monorepo run the same Node version
Categories
(Taskcluster :: Services, enhancement)
Tracking
(Not tracked)
People
(Reporter: owlish, Assigned: owlish)
References
Details
Options:
- Write a metatest
- Research yarn's workspaces capabilities - maybe there's a way of ensuring the same engine version
- Use any other device (
.taskcluster.yml
?) to prevent different services running on different Node versions
Comment 1•6 years ago
|
||
What happens now if a engines
property in some package.json
is wrong?
Comment 2•6 years ago
|
||
Another thing that maybe we can consider is to actually make all of the services on package? That would require them using the same versions of libraries but I think that's the only thing stopping us. The rest of package.json is kinda useless for them afaict.
I don't think it matters a whole lot if engines is wrong. It would just be nice if they were the same.
Comment 3•6 years ago
|
||
Let's hold off on that for a bit. I think when we get more stuff in the monorepo, and less not in it, and are only deploying to GKE, we can think about making the whole thing one big JS project.
Assignee | ||
Comment 4•6 years ago
|
||
Fresh development: Heroku doesn't read engine from individual package.json
, so for now I have engine in the monorepo root package.json
only.
Also, when running tests locally, individual package.json
overrides the root one. I haven't experimented with GKE deployments yet. So for now makes sense all-round to just keep engine in one place - in the root package.json
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
I saw Dustin added a metatest asserting the Node version is the same in package.json
and .taskcluster.yml
, which seems to have sealed this bug. Appears to be resolved now? I am closing it for now
Comment 6•6 years ago
|
||
I didn't mean to steal your bug, but if that's what was necessary, great!
Assignee | ||
Comment 7•6 years ago
|
||
Oh I didn't mean that at all! The most important thing - it needed to be done, and it's awesome you did it! I just wasn't sure if the bug was resolved or not
Updated•6 years ago
|
Description
•