Remove the sync telemetry histogram
Categories
(Firefox :: Search, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: mikedeboer, Assigned: manishkk)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
During the review phase of bug 1492475, we noticed that the 'SEARCH_SERVICE_INIT_SYNC' Telemetry Histogram doesn't really serve a purpose anymore, because we simply removed the synchronous initialization path!
Assignee | ||
Comment 1•6 years ago
|
||
need to remove this only?
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json#8159-8165
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 3•6 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically.
Please manually rebase your commits and try again.
Hunk #1 FAILED at 2733
Hunk #2 succeeded at 2683 with fuzz 2 (offset -95 lines).
1 out of 2 hunks FAILED -- saving rejects to file toolkit/components/search/nsSearchService.js.rej
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 5•6 years ago
|
||
Hi Manish, does this still need to be landed after c#4? If that's the case the the modifications made need to be review by mikedeboer in order to be landable via Phabricator. Thanks.
Updated•6 years ago
|
Comment 6•6 years ago
|
||
bugherder |
Assignee | ||
Updated•6 years ago
|
Description
•