Closed Bug 1518551 Opened 6 years ago Closed 6 years ago

Remove the MOZ_TOOLKIT_SEARCH define

Categories

(Firefox :: Search, task, P2)

Product:
Firefox
Component:
Search
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Iteration:
68.3 - Apr 15 - 28
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1518551 - Remove the 'MOZ_TOOLKIT_SEARCH' build config constant, because it's unused; we always enable the search service. r?florian!
(deleted), text/x-phabricator-request
Details

During the review phase of bug 1492475, we noticed that the 'MOZ_TOOLKIT_SEARCH' build-time define doesn't really serve a purpose anymore.
Let's remove it.

need to remove only 'MOZ_TOOLKIT_SEARCH' from here: https://searchfox.org/mozilla-central/search?q=MOZ_TOOLKIT_SEARCH&case=false&regexp=false&path=

Flags: needinfo?(mdeboer)
Assignee: nobody → 1991manish.kumar

Yes, I think that's correct, Manish. Thanks for taking a look!

Flags: needinfo?(mdeboer)
Attached file Bug 1518551- Remove the MOZ_TOOLKIT_SEARCH define (obsolete) (deleted) —

Hi Manish, did you see Mike's comments on the patch?

Are you still working on this?

Type: enhancement → task
Points: --- → 1
Flags: needinfo?(1991manish.kumar)

Sorry not able to give time because of my Ph.D.
I am un-assigning this bug.

Flags: needinfo?(1991manish.kumar)
Assignee: 1991manish.kumar → nobody
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Priority: P3 → P2
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da2bd2908b71 Remove the 'MOZ_TOOLKIT_SEARCH' build config constant, because it's unused; we always enable the search service. r=florian

https://hg.mozilla.org/mozilla-central/rev/da2bd2908b71

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Iteration: --- → 68.3 - Apr 15 - 28
Attachment #9041426 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: