Closed Bug 1518921 Opened 6 years ago Closed 6 years ago

Discovery Stream Spocs

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 66
Iteration:
66.3 - Jan 7 - 20
Tracking Status
firefox66 --- fixed

People

(Reporter: thecount, Assigned: thecount)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

New spoc functionality has spoc endpoint being returned from the layout.

It's a single list and needs to be fetched, cached, and put into redux, similar to feeds.

Blocks: 1513253
Assignee: nobody → sdowne
Blocks: 1512725
Severity: normal → enhancement
Iteration: --- → 66.3 - Jan 7 - 20
Priority: -- → P1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Keywords: github-merged
Resolution: FIXED → ---
Blocks: 1520324
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Hi,

Any updates on QA steps?

Flags: needinfo?(sdowne)

It might be tricky to know what's a spoc and what's not, as the data might change. At the time I wrote this spocs are about credit cards. I might take the time to make a fake spoc response so it won't change.

  1. set your browser.newtabpage.activity-stream.discoverystream.config pref to {"enabled":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/1be633daea7d1ce65a8ca903a3be9ae9/raw/3d51663327126879f6fa1c6b3e7730e7805c9e1e/spocs"}
  2. Load a new tab, take note of the 3rd card in both the card grid and hero grid.
  3. Refresh a couple times, noting the 3rd card in each refresh.

Expected: The third position on each hero and card component has a 50% chance to be a spoc.

There are 4 combinations based on the rolls you get.

  1. where both rolls fail, and in this case you see the same card in both positions in both components because they share the same feed.

  2. where the card component rolls a spoc and the hero does not.

  3. where hero has a spoc and card doesn't.

  4. And finally where they both have spocs.

Flags: needinfo?(sdowne)

QA Results :

Tested on :

FF Nightly version : 66.0a1 (2019-01-18)

OS : Mac

Works as expected.

Result can be found here :

Recording : https://www.dropbox.com/s/y3oab5kbtgc6fgs/bug%201518921.mp4?dl=0

Closing as verified.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: