Set window handle for "switch_to_window" also as "handle"
Categories
(Remote Protocol :: Marionette, enhancement, P3)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: whimboo, Assigned: kritisingh1.ks, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=py])
User Story
To get started follow the documentation at: https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
To get started on bug 1301073 we have to make marionette client backward compatible by also setting the window handle as "handle" here:
The "name" property should be left-in for now to stay compatible. Best would be to also rename window_id to handle.
|
Reporter | |
Comment 2•6 years ago
|
||
Hey Utkarsh, feel free to get started and let me know if you face problems which you cannot solve on your own. Make sure to check the link in the user story above for all the documentation.
|
||
Updated•6 years ago
|
|
|
Reporter | |
Comment 4•6 years ago
|
||
As comment 0 explained there are two steps. First rename window_id to handle, and then add another handle key to the dictionary which gets passed as body.
|
||
Comment 5•6 years ago
|
||
Hi,
Is someone working on this?
If not, @whimboo can I work on this? I am a a beginner and this will be my first task:)
whimboo: do I have to initialize my local repo in mozilla-central or in the repo in which I am making my bug changes (marionette_driver)?
|
|
Reporter | |
Comment 8•6 years ago
|
||
Did you read the documentation? You would have been guided to https://mozilla-version-control-tools.readthedocs.io/en/latest/hgmozilla/unifiedrepo.html. So please clone that.
prajwalshimpi, if you are looking for a place to contribute maybe bug 1506829 would be something for you.
|
|
Reporter | |
Comment 10•6 years ago
|
||
I already explained everything in detail in comment 4. If it is too hard for you it might not be the best bug for you then. Please let us know if you want to continue or not.
|
||
Comment 11•6 years ago
|
||
Could you tell me which dictionary are you referring to?
|
|
Reporter | |
Comment 12•6 years ago
|
||
Please see the link in my original comment, which directly points to that.
|
|
Reporter | |
Comment 13•6 years ago
|
||
The same issue we had in geckodriver and will soon be fixed by bug 1519053. Maybe someone wants to pick this up now?
|
Assignee | |
Comment 14•6 years ago
|
||
:whimboo this seems quite similar to Bug 1519053. I would like to pick this up. Thanks!
|
|
Reporter | |
Comment 15•6 years ago
|
||
Absolutely! Thanks a lot.
|
|
Assignee | |
Comment 16•6 years ago
|
||
|
||
Comment 17•6 years ago
|
||
|
||
Comment 18•6 years ago
|
||
| bugherder | ||
|
||
Updated•6 years ago
|
|
||
Updated•2 years ago
|
Description
•