Closed Bug 1519062 Opened 6 years ago Closed 5 years ago

Theme preview causes flicker on load

Categories

(Toolkit :: Add-ons Manager, defect, P3)

66 Branch
x86_64
Windows 7
defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox66 --- wontfix
firefox67 --- wontfix
firefox67.0.1 --- wontfix
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: Virtual, Assigned: robwu, Mentored)

References

Details

(Keywords: nightly-community, Whiteboard: [fixed by patch from bug #1555012])

Attachments

(1 file)

  1. Use some external Light Themes/Appearances/Personas not build in browser (like https://addons.mozilla.org/addon/virtualfox/ for example)
  2. Open Add-ons Manager (about:addons)
  3. Open Themes tab
    and see that Preview of Light Themes/Appearances/Personas flickers/blinks/flashes on opening Themes tab in Add-ons Manager (about:addons)

Swap between Themes tab and Extensions or Plugins tab to reproduce it reliably.

Attached video Screencast.mp4 (deleted) —

Assuming that this is LWT, wontfix pending imminent migration.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX

This affects static themes as well. Making this a P3 since it's annoying but I don't know if I'll have time to get to it.

The easiest solution is probably to force a height when there is a preview image. This might need to be adjusted once the image actually loads in case it's an incorrect size for some reason.

Another solution would be to delay switching the view until the images have been loaded. This would likely avoid any resizing once the view is ready but is also likely more work, and delaying the page load isn't ideal.

Mentor: mstriemer
Status: RESOLVED → REOPENED
Priority: -- → P3
Resolution: WONTFIX → ---
Summary: Preview of Light Themes/Appearances/Personas flickers/blinks/flashes on opening Themes tab in Add-ons Manager (about:addons) → Theme preview causes flicker on load

I can't reproduce it anymore after landing patch from bug #1555012, so I'm marking this bug as FIXED.

@ Mark Striemer [:mstriemer] - Could you confirm this please, that it doesn't need to be fixed elsewhere?

Assignee: nobody → rob
Depends on: 1555012
Flags: needinfo?(mstriemer)
Whiteboard: [fixed by patch from bug #1555012]
Target Milestone: --- → mozilla69
Status: NEW → RESOLVED
Closed: 6 years ago5 years ago
Resolution: --- → FIXED

This is indeed fixed.

Flags: needinfo?(mstriemer)

Thank you very much for confirmation.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: