Closed
Bug 1519114
Opened 6 years ago
Closed 6 years ago
Port Bug 1454357 Remove scrollbox binding
Categories
(Calendar :: General, enhancement)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
6.8
People
(Reporter: jorgk-bmo, Assigned: Paenglab)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
After fixing the massive failure in bug 1519078, we're left with some MozMill Calendar failures:
I've run
mozmake -C comm/calendar/test/mozmill SOLO_TEST=testTodayPane.js mozmill-one
I see
JavaScript error: chrome://calendar/content/calendar-multiday-view.xml, line 2532: TypeError: document.getAnonymousElementByAttribute(...) is null
And that code is:
let scrollbox = document.getAnonymousElementByAttribute(
this, "anonid", "scrollbox");
document.getAnonymousElementByAttribute(
scrollbox, "class", "box-inherit scrollbox-innerbox").flex = "1";
Flags: needinfo?(richard.marti)
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)
Flags: needinfo?(arshdkhn1)
|
Assignee | |
Comment 1•6 years ago
|
||
This fixes the calendar issue for me. Without patch, opening the event tab makes TB very, very wide (around 3400px). With patch the views in the event tab look like they should.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)
Flags: needinfo?(arshdkhn1)
Attachment #9035671 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9035671 [details] [diff] [review]
1519114-no-scrollbox-innerbox.patch
Review of attachment 9035671 [details] [diff] [review]:
-----------------------------------------------------------------
Great, thx Richard! r=mkmelin
Attachment #9035671 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
I checked also that this was our only occurrence of scrollbox-innerbox in the tree.
Keywords: checkin-needed
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/98ce18ce0ea7
Port Bug 1454357 Remove scrollbox binding. r=mkmelin
|
||
Updated•6 years ago
|
Target Milestone: --- → 6.8
You need to log in
before you can comment on or make changes to this bug.
Description
•