Closed
Bug 1519243
Opened 6 years ago
Closed 6 years ago
CSS updates for topics header section component
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: k88hudson, Assigned: thecount)
References
Details
(Keywords: github-merged)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-github-pull-request
|
Details |
We would to adjust the topics header section to match the design specs; this will mostly be style and modifying HTML.
|
Reporter | |
Updated•6 years ago
|
Priority: P2 → P3
|
|
Reporter | |
Updated•6 years ago
|
Priority: P3 → P2
|
||
Comment 1•6 years ago
|
||
|
Assignee | |
Updated•6 years ago
|
Attachment #9035980 -
Attachment is obsolete: true
|
||
Comment 2•6 years ago
|
||
The "More Recommendations" should be optional. Sounds like design wants to be able to use SectionTitle to show a single link, e.g., "More Trending Stories >" and "Earlier Stories >"
|
|
||
Comment 3•6 years ago
|
||
sounds like renaming the current SectionTitle to a navigation component
- dot-separated links with a name/url
- link hover/click states
- no more hardcoded "More Recommendations"
new SectionTitle
- optional main header text
- optional subtitle text
- with icon / not
- with info / not
|
|
||
Comment 4•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Iteration: 67.1 - Jan 28 - Feb 10 → 66.4 - Jan 21 - 27
|
||
Comment 5•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/fbde1fb0fc3e90f2b7eab991a0ce27ca636c8ebd
Bug 1519243 - Split title component into two, the new one is navigation (#4688)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sdowne
|
|
||
Comment 6•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
Assignee | |
Comment 8•6 years ago
|
||
No QA steps required.
Status: RESOLVED → VERIFIED
Flags: needinfo?(sdowne)
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•