Closed
Bug 1519773
Opened 6 years ago
Closed 6 years ago
implement image placeholder style for list items
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: dmosedale, Assigned: Mardak)
References
Details
(Keywords: github-merged)
User Story
QA steps: use dev-test-all and make sure any image shows the gray placeholder before the image is loaded. This depends on internet connection, but if you continuously refresh the page, you should see a brief flash of gray background.
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
No description provided.
|
||
Updated•6 years ago
|
Iteration: --- → 66.3 - Jan 7 - 20
Priority: -- → P2
|
|
||
Updated•6 years ago
|
Iteration: 66.3 - Jan 7 - 20 → 66.4 - Jan 21 - 27
|
|
||
Updated•6 years ago
|
Priority: P2 → P1
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → edilee
|
||
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/05d0f8ceb592d5826b4a2ff016b63496f1e6e17c Bug 1519773 - implement image placeholder style for list items and share as mixin (#4714)
|
|
Assignee | |
Updated•6 years ago
|
Keywords: github-merged
|
|
Assignee | |
Updated•6 years ago
|
User Story: (updated)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Comment 4•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-01-30)
OS : Mac and Windows 10 Pro
Results (recording) :
https://www.dropbox.com/s/w3ksq2nu3l2amww/QA%20Results%20%3A%20bug%201519773.mp4?dl=0
Note :
Image placeholders for Topsites are not noticeable.
Per @WolasoiKonu "that’s fine since we’re using the existing top site component and aren’t making ux changes to it for v66".
So apart from Topsites placholders works as expected for other images.
Closing as verified.
|
|
||
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•