Closed
Bug 1519775
Opened 6 years ago
Closed 6 years ago
implement one and two-story wide list layout
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
(Keywords: github-merged)
User Story
How to test:
* go to about:config
* search for stream.config
* set that preference to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
* open a new tab
The various trending stories should all be appropriate widths.
Things to note:
* some horizontal rules above or below individual stories may be incorrectly there or incorrectly missing. https://bugzilla.mozilla.org/show_bug.cgi?id=1521119 has been filed.
Known bugs are already captured as dependents of the ds-list-component bug: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1514020&hide_resolved=0
Attachments
(3 files)
Trending Stories Image module- Mac OS.png
No description provided.
|
||
Updated•6 years ago
|
Iteration: --- → 66.4 - Jan 21 - 27
|
Assignee | |
Updated•6 years ago
|
Summary: implement two-story-wide list layout → implement one and two-story wide list layout
|
||
Comment 2•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Iteration: 66.4 - Jan 21 - 27 → 66.3 - Jan 7 - 20
|
||
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/f558744a1dcc86a870b34f3926425ee21bf09465
Bug 1519775 - Make one and two-column lists work (#4685)
|
|
Assignee | |
Updated•6 years ago
|
Keywords: github-merged
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dmose
Priority: -- → P1
|
||
Comment 4•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
Assignee | |
Updated•6 years ago
|
User Story: (updated)
Flags: needinfo?(dmose)
|
||
Comment 6•6 years ago
|
||
Test failed.
QA Result :
Tested on :
FF Nightly version : 66.0a1 (2019-01-22)
OS : Mac and Windows 10 Pro
I'm observing different widths on Mac vs Windows 10 Pro.
Mac :
- All of the image module dimensions are
72x72except the highlighted module in the attachmentTrending Stories Image module- Mac OS.pngwhich hasimg ds-list-image=50.0167x72 - All of those same item modules in different
Trending storieshave these dimensions. Meaning - out of the 6 modules underTrending stories3rd module is different from the rest.
Windows 10 Pro :
- All of the image module dimensions are
72x72except the highlighted module in the attachmentWindows OS - trending Stories image module.pngwhich hasimg ds-list-image=53.2667x72 - All of those same item modules in different
Trending storieshave these dimensions. Meaning - out of the 6 modules underTrending stories3rd module is different from the rest.
In short img ds-list-image for :
Mac OS = 50.0167x72
Windows 10 Pro = 53.2667x72
Flags: needinfo?(dmose)
|
|
||
Comment 7•6 years ago
|
||
|
|
||
Updated•6 years ago
|
Severity: enhancement → normal
|
|
||
Comment 8•6 years ago
|
||
Tracking above issue here : bug 1522328
Note :
QA needs to re-test once the bug 1522328 is fixed.
Closing bug.
No longer blocks: 1522328
|
|
||
Updated•6 years ago
|
Severity: normal → enhancement
|
|
||
Updated•6 years ago
|
Flags: needinfo?(dmose)
|
|
||
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•