Additional license notices for libgcrypt etc. needed by Thunderbird
Categories
(Chat Core :: Security: OTR, enhancement)
Tracking
(thunderbird_esr68 fixed, thunderbird69 fixed, thunderbird70 fixed)
People
(Reporter: KaiE, Assigned: KaiE)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
This was originally mentioned in bug 1518091. Forked here as separate bug. This is relevant if we are indeed adding libcrypt.
libgcrypt includes some code with additional (compatible) licenses, which requires that permission notices are included. We'll have to check which of the following require additions to about:license:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=blob;f=LICENSES;h=f6733a69246bb2d0236af42cff28c1a6fee43c36;hb=HEAD
|
Assignee | |
Comment 1•5 years ago
|
||
Thunderbird will import additional third party licenses into its source tree, which will require additional license notices in the binary, so they must be included in about:license.
Should these additions be made to the general set of licenses contained in toolkit? Or should they become private additions only for the mail applications, only (inside the comm repository).
If you "only add to Mail app's set of licenses", how should we do that technically? Will we need scripts, that use build time logic to combine the contents of toolkit/content/license.html with additional contents for comm applications?
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
This patch requires the suggested enhancement from bug 1559900.
It adds the license notices from libgcrypt.
The other libraries, libgpg-error and libotr, don't seem to need additional notices, beyond what we already show.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
Adjusted for patch v2 from bug 1559900.
|
|
Assignee | |
Comment 4•5 years ago
|
||
There's a circular dependency between this bug and bug 1518164.
We cannot import the code until we have the license added.
However, before we can add the license, we need to know in which directory the code will be placed, because the license page mentions the filenames that the license is related to. And that's being discussed in bug 1518164.
|
|
Assignee | |
Comment 5•5 years ago
|
||
It has been clarified that we'll use directory name third_party (toplevel in comm-central). I'll attach an updated patch.
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 7•5 years ago
|
||
Once reviewed, this will require uplift to the comm-esr68 branch.
It depends on bug 1559900, we'll need to uplift that one to Thunderbird's v68 release branch of mozilla-esr68.
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 8•5 years ago
|
||
|
|
||
Comment 9•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/082bd1210cb5
Add additional license notices for libgcrypt, etc. r=mkmelin
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 11•5 years ago
|
||
|
|
||
Comment 12•5 years ago
|
||
|
|
||
Comment 13•5 years ago
|
||
|
|
||
Comment 14•5 years ago
|
||
|
||
Updated•5 years ago
|
Description
•