Closed
Bug 1519878
Opened 6 years ago
Closed 6 years ago
implement full width ds-list items
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: dmosedale, Assigned: Mardak)
References
Details
(Keywords: github-merged)
User Story
QA steps: use dev-test-all and check that all "Full width" sections (towards the bottom in the 2/3-wide left side) have images and have one item per row as well as show borders and/or numbers as appropriately titled
Attachments
(2 files)
QA Results : bug - 1519878.png
These double-wide items will also have double-wide images.
|
Reporter | |
Updated•6 years ago
|
Summary: implement double-wide ds-list items → [stretch] implement double-wide ds-list items
|
||
Updated•6 years ago
|
Iteration: --- → 66.4 - Jan 21 - 27
|
|
||
Updated•6 years ago
|
Priority: -- → P1
|
Assignee | |
Comment 1•6 years ago
|
||
Potentially any list can be full width instead of split into 1/3 columns.
This is specified with a property full_width: true
These include the excerpt (unlike other Lists)
Design says these will only be used with an image (but that's just a separate has_images property)
The images are 2x as wide so 144px.
Assignee: nobody → edilee
Summary: [stretch] implement double-wide ds-list items → [stretch] implement full width ds-list items
|
||
Comment 2•6 years ago
|
||
|
||
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/55ef6c13a1bdeb5d857390b5475510840cb1890c Bug 1519878 - implement full width ds-list items (#4726)
|
|
Assignee | |
Updated•6 years ago
|
Keywords: github-merged
Summary: [stretch] implement full width ds-list items → implement full width ds-list items
|
|
Assignee | |
Comment 4•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
Assignee | |
Updated•6 years ago
|
User Story: (updated)
Flags: needinfo?(edilee)
|
|
Assignee | |
Updated•6 years ago
|
User Story: (updated)
|
||
Comment 6•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-01-31)
OS : Mac and Windows 10 Pro
Results attached QA Results : bug - 1519878.png
All "Full width" sections (towards the bottom in the 2/3-wide left side) have images and have one item per row as well as show borders and/or numbers as appropriately titled.
Closing as verified.
|
|
||
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•