Closed
Bug 1520088
Opened 6 years ago
Closed 6 years ago
Sites' autoplay preference is overridden by global autoplay preference
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
VERIFIED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | verified |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(5 files)
STR.
- go to
about:preferences#privacy
- Find the autoplay setting area
- Click
Exceptions
and chooseblock
for "https://alastor0325.github.io/" - Click
Save Changes
and go back toabout:preferences#privacy
- Uncheck the check box for
Block websites from automatically playing media with sound
- go to "https://alastor0325.github.io/htmltests/autoplay_tests/autoplay_test1.html"
Expected.
7. video should not be allowed to start, because we have added the site into the blacklist
Actual.
7. video starts playing automatically
Assignee | ||
Updated•6 years ago
|
Summary: Site's autoplay preference is override by global autoplay preference → Sites' autoplay preference is overridden by global autoplay preference
Assignee | ||
Comment 1•6 years ago
|
||
We would like to have different phases checking for autoplay, the first phase is to check media element itself, so we need to move other non-related checkings out from 'IsMediaElementAllowedToPlay()'.
Assignee | ||
Comment 2•6 years ago
|
||
Ensure we can always see the debug log for the autoplay result.
Assignee | ||
Comment 3•6 years ago
|
||
The autoplay checking for media element has 4 different phases,
1. check whether media element itself meets the autoplay condition
2. check whethr the site is in the autoplay whitelist
3. check global autoplay setting and check wether the site is in the autoplay blacklist.
4. check whether media is allowed under current blocking model (click-to-play or user-gesture-activation)
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Updated•6 years ago
|
Rank: 15
Priority: -- → P2
Assignee | ||
Comment 7•6 years ago
|
||
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb086e6c019f
part1 : let 'IsMediaElementAllowedToPlay()' only check media element's attributes r=cpearce
https://hg.mozilla.org/integration/autoland/rev/1d2fcf021b32
part2 : ensure logging result can always be executed. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/2ce9b482cda2
part3 : implement different phases autoplay checking. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/5e0eb1c00744
part4 : modify test. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/5a384547b8b3
part5 - add pref to control whether blacklist can override the default setting. r=cpearce
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb086e6c019f
https://hg.mozilla.org/mozilla-central/rev/1d2fcf021b32
https://hg.mozilla.org/mozilla-central/rev/2ce9b482cda2
https://hg.mozilla.org/mozilla-central/rev/5e0eb1c00744
https://hg.mozilla.org/mozilla-central/rev/5a384547b8b3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Comment 10•6 years ago
|
||
Hi, This issue no longer occurs in the latest nightly build, the Exceptions functionality works even with the feature turned off, I will mark this issue accordingly.
This issue was verified in the latest Nightly Build:
https://tools.taskcluster.net/index/gecko.v2.mozilla-central.latest.firefox
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•