Closed Bug 1520096 Opened 6 years ago Closed 5 years ago

Enable reftests introduced in bug 1423013 on WebRender

Categories

(Core :: Layout, enhancement, P3)

64 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file)

Something has been changed, I am pretty sure those reftests passed on WebRender before. But now they fail for some reasons.

I am going to land the patches for bug 1423013 with skipping the failed reftests and, I will revisit here once it gets landed.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4e8f301a325e49c1c36c877dda81db708a35d95&selectedJob=221884342

I'm not sure what the state of zooming with WR is. To run zooming tests on desktop, we enable container scrolling, which may interact badly with WR. Bug 1459312 should help sort this out.

Zooming with WR generally does work on Android. Hiro, if you need any help with the WR side of things let me know in the next week or so and I can help.

Thanks for reminder. I will check the result on the current trunk.

Flags: needinfo?(hikezoe)

There are still 6 reftest failures on WebRender. The symptoms of 6 failures look pretty much the same as bug 1561215. The area which is initially outside of the visual viewport (i.e. before expanding it to the minimum scale size) isn't rendered at all. I remember the test case worked on WebRender to some extent, so I did bisect it. Bug 1558106 is the culprit, but it's a huge changeset, I have no idea what was changed at first glance.

Depends on: 1563717
Flags: needinfo?(hikezoe.birchill)

The reason of failures has been solved by bug 1563717.

Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32c8c81f06a4
Enable reftests related to meta viewport tags on WebRender. r=botond
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → hikezoe.birchill
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: