Closed Bug 1520107 Opened 6 years ago Closed 6 years ago

tbody in Accessibility Tree gets focused when opening the context menu

Categories

(DevTools :: Accessibility Tools, defect)

defect
Not set
normal

Tracking

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 wontfix, firefox66 fixed)

RESOLVED FIXED
Firefox 66
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: Jamie, Assigned: yzen)

References

Details

(Keywords: regression)

Attachments

(1 file)

STR (with NVDA):

  1. Open any document; e.g. data:text/html,foo
  2. Open the page context menu and select Inspect Accessibility Properties.
  3. Focus the Accessibility Tree.
  4. Use the arrow keys to select a node.
  5. Right click on the node to open the context menu.
    Expected: NVDA should say "menu".
    Actual: NVDA says "text frame" then "menu".
  6. Press escape to dismiss the menu.
    Expected: NVDA should speak the item selected in step 4.
    Actual: NVDA speaks "text frame" instead of the item.

I think the tbody gets DOM focus when you click in the tree view. It does have role="presentation", but we ignore that for nodes which can get DOM focus. Assuming I'm correct (I haven't looked at the code), there are two possible solutions:

  1. The tbody shouldn't be focusable. This has the added benefit of pruning the tbody from the a11y tree. While the ideal solution, I'm guessing it had to be made focusable for some implementation reason.
  2. Set aria-activedescendant on the tbody to also reference the active tree item. This way, when the tbody does get focus, a11y clients won't really notice it.

This used to work fine, so I'm marking this as a regression.

Keywords: regression
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/611bd5949e83 fix focus and keyboard triggered context menu handling in a11y panel tree. r=gl
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/50cc5c5bd5ef fix focus and keyboard triggered context menu handling in a11y panel tree. r=gl
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6aa3c460ff66 fix focus and keyboard triggered context menu handling in a11y panel tree. r=gl
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Flags: needinfo?(yzenevich)

Too late for 65.

Blocks: 1507870
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: