Closed
Bug 1520241
Opened 6 years ago
Closed 6 years ago
TestSPSCQueue.exe is very slow on Windows
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The cppunittest TestSPSCQueue.exe takes so long on my Windows machines that it times out. This is because there are nested loops trying to sleep for 10 microseconds, but Windows's default timer resolution turns each one into a 16ms sleep.
Apparently the automation machines have their system timer resolution set to 1ms, which makes the test take "only" 2.5 mins. I can get the same effect on my machines by adding timeBeginPeriod(1) (a trick we use in the profiler and elsewhere), but talking to padenot, that's still too long for this test. Let's just Sleep(0) and hope for the best.
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5876723df7ba
Avoid slow sleeps on Windows in TestSPSCQueue.exe r=padenot
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Updated•6 years ago
|
Assignee: nobody → dmajor
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•