devtools/client/inspector/markup/test/browser_markup_events* failures when using `allFrames: true` for a ChildActor
Categories
(DevTools :: Inspector, defect)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [fixed by bug 1042082])
Attachments
(2 files)
Screenshot showing ActorManagerChild.jsm pagehide/pageshow listeners on <html>
browser_markup_events*.js tests fail if I register a ChildActor with allFrames: true because the developer tools inspector sees the pagehide/pageshow events added by ActorManagerChild.jsm on the window[1]. See attachment 9036482 [details] [diff] [review] for a minimal patch to register an allFrames: true actor and reproduce the problem.
It's possible that bug 1520075 will change the SingletonDispatcher class to avoid this problem, otherwise maybe we need to filter these events out of the developer tools?
:gl, do you know if we already try to filter out certain chrome/webext events from showing in the event tooltip? I didn't see any of that happening in [2] but perhaps it's somewhere else.
[1] https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/toolkit/modules/ActorManagerChild.jsm#187-188
[2] https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/devtools/server/actors/inspector/node.js#411
|
||
Comment 1•6 years ago
|
||
Hey Mike, you might know more about this area than myself.
Thanks for letting us know about this bug... I will add it to my list.
|
Assignee | |
Comment 3•6 years ago
|
||
Does that mean you consider it a devtools bug that it doesn't filter out these non-site event listeners? This is blocking bug 1474143 from landing so a solution or workaround would be good.
@MattN I think we can filter out the events.
If this is blocking I can prioritize it.
I am blocked by bug 1520823.
Actually, chrome event listeners shouldn't be listed in the content debugger but we should list them in the browser debugger.
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 7•6 years ago
|
||
Hmm… the tests still permafailed on ASAN only: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&group_state=expanded&searchStr=dt6&fromchange=1b5d0486658571aed2d5ea68281f13cc627cb5d5&tochange=49fda807b7c5b867fca271115934ccb6a8c7e205
|
|
Assignee | |
Comment 8•6 years ago
|
||
This already matches the behaviour for unofficial (e.g. local and asan) builds.
|
|
Assignee | |
Comment 9•6 years ago
|
||
They also permafail on local builds. I believe the reason is the different default value of devtools.chrome.enabled: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/devtools/shared/preferences/devtools-shared.js#26-30
|
||
Comment 10•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
|
|
||
Comment 12•6 years ago
|
||
| bugherder | ||
Description
•