Closed
Bug 1520514
Opened 6 years ago
Closed 6 years ago
Add memoized selector to add feed data and spocs to layout
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: k88hudson, Assigned: k88hudson)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
In order to calculate a persistent setting for spocs based on layout, spoc, and feed data, we need to add a memoized selector that can be used by components.
Instead of accessing DiscoveryStream.layout directly, components will use a function to process the state coming from the reducer.
|
||
Comment 1•6 years ago
|
||
|
Assignee | |
Comment 2•6 years ago
|
||
Note for QA: No additional testing is needed for this patch beyond ensuring no regressions have been introduced.
|
||
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/7529c0a4bc8bb1d949cec1415fa954a0174b2801
Bug 1520514 - Add memoized selector to add feed data and spocs to layout
|
|
Assignee | |
Updated•6 years ago
|
Keywords: github-merged
|
||
Comment 4•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
Assignee | |
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•