Closed
Bug 1520854
Opened 6 years ago
Closed 6 years ago
text-color in AS dark theme regressed to grey by DS change
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox64 | --- | unaffected |
| firefox65 | --- | unaffected |
| firefox66 | --- | fixed |
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
(Keywords: github-merged, regression)
User Story
How to test:
* In a clean profile, set your computer's OS to use dark theme (on Mac, this is System Preferences -> General).
* Open a new tab
* For the pocket cards, the title and excepts should be a legible light grey
Then, to ensure that this fix hasn't regressed the original thing it was intended to address.
* Reset your computer's OS theme use a light theme
* go to about:config
* search for stream.config
* set that preference to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
* open a new tab
Verify that the text in the title of the Trending Stories list items is #0C0C0D
Attachments
(2 files)
QA Result - 1520854.png
Bug 1519766 regressed the test color in Activity-Stream dark mode:
https://github.com/mozilla/activity-stream/commit/6967f2e7a0402133c93b82997b280e3ab1d99ffb#r31975015
|
||
Comment 1•6 years ago
|
||
|
Assignee | |
Updated•6 years ago
|
User Story: (updated)
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/6051ed1c09b74cebc173d3ebf4828c3d7f667c11 Bug 1520854 - make text color in AS work again in dark theme (#4681)
|
|
Assignee | |
Updated•6 years ago
|
Keywords: github-merged
|
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P1
|
||
Comment 4•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Comment 5•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 66.0a1 (2019-01-18)
OS : Mac and Windows 10
Attaching screenshot of the result "QA Result - 1520854.png"
Looks good to me.
Closing bug as verified.
|
|
||
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•6 years ago
|
status-firefox64:
--- → unaffected
status-firefox65:
--- → unaffected
status-firefox-esr60:
--- → unaffected
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•