XML Parsing Error: undefined entity Location: chrome://messenger/content/hiddenWindow.xul
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(thunderbird65 fixed, thunderbird66 fixed)
People
(Reporter: florian, Assigned: florian)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
XML Parsing Error: undefined entity
Location: chrome://messenger/content/hiddenWindow.xul
Line Number 1248, Column 17:
<menuitem label="&openAllAttachmentsCmd.label;"
[Exception... "[JavaScript Error: "browser is null" {file: "resource:///modules/hiddenWindow.jsm" line: 16}]'[JavaScript Error: "browser is null" {file: "resource:///modules/hiddenWindow.jsm" line: 16}]' when calling method: [prplIAccount::connect]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: file:///.../obj-x86_64-apple-darwin17.7.0/dist/Thunderbird%20Daily.app/Contents/Resources/components/imAccounts.js :: connect :: line 724" data: yes]
This prevents chat accounts from connecting, making it impossible to test bug 1519091 on Mac.
This is a regression caused by bug 1519481, patch coming.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
(In reply to Florian Quèze [:florian] from comment #0)
This prevents chat accounts from connecting, making it impossible to test bug 1519091 on Mac.
This is a regression caused by bug 1519481, patch coming.
Can you please elaborate on this? You're saying chat is broken on TB 65 beta 3 which I've just built?
https://treeherder.mozilla.org/#/jobs?repo=comm-beta&revision=34e099eeadc625db313577c93d025a6958ac86b4
On Mac only? It works fine on Windows, I've just tried it. What is that hiddenWindow.xul about?
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #2)
On Mac only?
Yes.
It works fine on Windows, I've just tried it. What is that hiddenWindow.xul about?
The code that you broke ensures we have a correct menubar at the top of the screen when Thunderbird is the active application but has no window.
Chat accounts fail to connect with the error I pasted in comment 0, because https://searchfox.org/comm-central/source/chat/modules/hiddenWindow.jsm breaks completely when the hidden window encounters a parse error.
Comment 4•6 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4badb35825a8
include msgHdrViewOverlay.dtd in hiddenWindow.xul to fix bustage caused by bug 1519481. r=jorgk DONTBUILD
Comment 6•6 years ago
|
||
TB 65 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/f8939fe0c3a8d827aa6d25f71e37a52a264d16ae
Updated•6 years ago
|
Description
•