Closed
Bug 1520888
Opened 6 years ago
Closed 6 years ago
Spocs ready state
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
Details
(Keywords: github-merged)
Attachments
(2 files)
Technically this is a everything ready state.
Needs to be set to true when layout, feeds, and potential spocs are fetched and ready to render. The reason why it's a spocs ready state is because spocs is the last to be fetched. It needs to fire if spocs are set or not.
Updated•6 years ago
|
Assignee: nobody → sdowne
Iteration: --- → 66.4 - Jan 21 - 27
Updated•6 years ago
|
Priority: -- → P1
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/148eae0956a66dd23af4322408d4343046189ae6
Bug 1520888 - Ensure spocs don't load over a rec. (#4701)
Updated•6 years ago
|
Keywords: github-merged
Comment 3•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Assignee | ||
Comment 4•6 years ago
|
||
To test:
If you're still seeing spocs with this pref: {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
You might need to scroll down a bit, but they should be in there as per usual.
Comment 7•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 66.0a1 (2019-01-25)
OS : Mac and Windows 10 Pro
Results Attached : QA Result : bug - 1520888.png
Closing as verified.
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•