Closed
Bug 1520889
Opened 6 years ago
Closed 6 years ago
Need to be able to turn spocs on and off via a pref and possibly an opt out
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
This is basically to align with the release functionality.
I dunno how much of a priority it is.
Updated•6 years ago
|
Assignee: nobody → sdowne
Iteration: --- → 66.4 - Jan 21 - 27
Updated•6 years ago
|
Priority: -- → P1
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
To test:
- Set pref
browser.newtabpage.activity-stream.discoverystream.config
to{"enabled":true,"show_spocs":false,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=control"}
- Ensure third card in a new tab is not a spoc.
- Set pref
browser.newtabpage.activity-stream.discoverystream.config
to{"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=control"}
andbrowser.newtabpage.activity-stream.showSponsored
totrue
- Ensure third card in a new tab is a spoc (should have a blue "sponsored by ..." label now).
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/46828d5f339e24cf31e25d009d51c0b41a8fc142
Bug 1520889 - Pref for toggling spocs on and off. (#4718)
* Bug 1520889 - Pref for toggling spocs on and off.
* review
Updated•6 years ago
|
Keywords: github-merged
Comment 4•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•