Closed
Bug 1520898
Opened 6 years ago
Closed 6 years ago
spocs info displayed in card
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
Details
(Keywords: github-merged)
Attachments
(2 files)
When a card is a spoc, we need to be like release and mention that somewhere.
Spocs return a line of text explaining who sponsored the card, we just need to display it in the card.
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Testing instructions.
- Ensure the new tab is the regular version by default.
- In
about:config
, changebrowser.newtabpage.activity-stream.discoverystream.config
to be{"enabled":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/e8ad372bc57ed3feba0bf02f89473fc9/raw/74daf564fea3e41e1ef24c39b18690623679182b/mrspocs"}
- Ensure new tab is rendering a bunch of spocs with the text "Sponsored by..." in a few. Specifically, it's in the last two on the card grid, and the first and last on the hero.
- Reset the pref, ensure everything is back to normal.
Updated•6 years ago
|
Assignee: nobody → sdowne
Iteration: --- → 66.4 - Jan 21 - 27
Updated•6 years ago
|
Priority: -- → P1
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/ed534b142246a543faa16c325cabcfe512825d64
Bug 1520898 - Display spoc context. (#4696)
Comment 4•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Comment 5•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 66.0a1 (2019-01-25)
OS : Mac and Windows 10 Pro
Results attached QA Result : bug - 1520898.png
Works as expected. Looks good to me.
Closing as verified.
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•