DebuggerServer is never destroyed in the content process
Categories
(DevTools :: Framework, enhancement, P2)
Tracking
(firefox66 fixed)
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
We are instantiating a DebuggerServer from the main frame script here:
https://searchfox.org/mozilla-central/rev/dac799c9f4e9f5f05c1071cba94f2522aa31f7eb/devtools/server/startup/frame.js#24-31
That we never ever try to destroy/cleanup.
It means that if we close the toolbox, the server is still around and may hold various objects alive, especially if actors are not cleaned up correctly.
And actually, the same also apply to the loader we create a few lines before, but that would be yet another level of cleanup.
In bug 1515290, I'm hitting this issue by having a test that report leaks on try, because we don't cleanup the server and leak objects indirectly from it.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
We never really tried to cleanup the DebuggerServer and so a few tests require some tweaks
to acknowledge that once the last connection drop (typically, we close the toolbox or target),
the server is destroyed and dynamically registered actors are also destroyed.
I think it is great to consider that everything is cleaned up as we may followup to destroy
the whole loader.
Depends on D16961
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
||
Updated•6 years ago
|
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b4cd1ef4baf0
https://hg.mozilla.org/mozilla-central/rev/c68ab257f8c8
Description
•