Closed
Bug 1521119
Opened 6 years ago
Closed 6 years ago
finish/correct implementation of individual horizontal rules above ds-list items
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
(Keywords: github-merged)
User Story
How to test:
* go to about:config
* search for stream.config
* set that preference to
{"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist.githubusercontent.com/dmose/80455b1826e7026abd488ec88d65afc4/raw/0305a22091bd98321867825f370ca609b37ee5cc/gistfile1.txt"}
* open a new tab
* press command (or control, windows) f to open the find bar
* click "whole words"
* enter "list" into the find bar
For the first list that comes up, make sure it has the right set of horizontal bars corresponding to the title. Which is to say, borderless lists should have none, every other list should have a horizontal bar above each of the stories (the top row will have a single horizontal bar all the away across, all other rows will have one bar per story).
* press command (or control on windows) g to find the next list and verify that. * repeat until you've gone through all the lists in the document.
Known bugs are already captured as dependents of the ds-list-component bug: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1514020&hide_resolved=0
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
Right now, they sometimes appear where they shouldn't, and are missing where they should be.
|
||
Updated•6 years ago
|
Priority: -- → P1
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dmose
|
||
Comment 1•6 years ago
|
||
wolasi also noticed that the whitespace below the first line seems to be smaller than the whitespace below the other item separators
|
||
Comment 2•6 years ago
|
||
|
||
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/254317ffe13b7602efe0b3f65361c564ba536207 Bug 1521119 - make list horizontal rules show up in right places (#4719)
|
|
Assignee | |
Updated•6 years ago
|
Keywords: github-merged
|
|
Assignee | |
Updated•6 years ago
|
User Story: (updated)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Bug 1522875 has been spun off to implement specific desired behavior for unbalanced rows, as mentioned in the review.
|
|
||
Comment 5•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
Assignee | |
Updated•6 years ago
|
User Story: (updated)
|
|
Assignee | |
Updated•6 years ago
|
User Story: (updated)
|
||
Comment 6•6 years ago
|
||
Numbers are seen under Lists even with the new end-point.
Tracking bug here : bug 1524048
Flags: needinfo?(dmose)
|
|
Assignee | |
Updated•6 years ago
|
User Story: (updated)
Flags: needinfo?(dmose)
|
|
||
Comment 7•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-01-31) (64-bit)
OS : Mac and Windows 10 Pro
Verified bug 1524048
Works as expected.
Closing as verified.
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•