Closed
Bug 1521132
Opened 6 years ago
Closed 6 years ago
Refactor maybeInjectSpocs into selectLayoutRender.js
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
Right now the maybeInjectSpocs function is in DiscoveryStreamBase, which it is probably better moved into selectLayoutRender.js
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sdowne
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Severity: normal → enhancement
Iteration: --- → 66.3 - Jan 7 - 20
Priority: -- → P1
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/6e20881656b31d469aad56e2276ecfa515a463bf
Bug 1521132 - Combine spoc rendering functions into selectLayoutRender.js (#4686)
Updated•6 years ago
|
Keywords: github-merged
Updated•6 years ago
|
Iteration: 66.3 - Jan 7 - 20 → 66.4 - Jan 21 - 27
Comment 3•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Assignee | ||
Comment 5•6 years ago
|
||
No QA steps required.
Status: RESOLVED → VERIFIED
Flags: needinfo?(sdowne)
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•