Closed Bug 1521151 Opened 6 years ago Closed 6 years ago

Flexbox Inspector grid lines and tracks error

Categories

(DevTools :: Inspector, defect, P2)

66 Branch
defect

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: 709922234, Assigned: miker)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image Screen Shot 2019-01-19 at 02.45.58.png (deleted) —

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

  1. open https://labs.jensimmons.com/2016/examples/image-gallery-flexbox-2.html
  2. open devtools & Flexbox Inspector
  3. Scroll the page horizontally
     

Actual results:

grid lines and tracks error

Component: Untriaged → Inspector
Product: Firefox → DevTools

I have reproduced on the latest nightly. However, I had to zoom into the page.

Needinfo'ing miker to diagnose the problem.

Blocks: dt-flexbox
Flags: needinfo?(mratcliffe)
Priority: -- → P2

Also confirmed after zooming (macOS with FF67).

Status: UNCONFIRMED → NEW
Ever confirmed: true

The Flexbox Inspector uses platform APIs that don't take zoom into account whilst the Grid Inspector uses APIs that do take zoom into account.

This means that the zoom calculations when repositioning the canvas need to be different when called from the Flexbox Inspector than when called from the grid inspector.

I have added a zoomWindow option to canvas.js::updateCanvasElement() that allows us to optionally apply zoom to the current canvas position and the flexbox issue reported in the bug now works just fine.

All the usual other test cases work just fine with this patch applied.

Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Flags: needinfo?(mratcliffe)
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/18a534223b49 Make Flexbox Inspector canvas take zoom into account when scrolling r=gl
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: