Make mach bootstrap download a nasm toolchain file
Categories
(Firefox Build System :: Toolchains, enhancement)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: TD-Linux, Assigned: TD-Linux)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
|
Assignee | |
Comment 1•6 years ago
|
||
Changing title as we can do this on Windows too.
|
||
Comment 2•6 years ago
|
||
Meanwhile I got this on Windows:
ERROR: nasm 2.13 or greater is required for AV1 support. Either install nasm or add --disable-av1 to your configure options.
So what is the process for "install nasm". The cbindgen message is more helpful: cargo install cbindgen --force.
|
||
Comment 3•6 years ago
|
||
For now you can do ./mach artifact toolchain --from-build win64-nasm which will download it from taskcluster and unpack it into your current dir. Then I guess you need to put it on your $PATH (I tried moving it to ~/.mozbuild/nasm/nasm.exe but it didn't get auto-detected there).
|
|
||
Comment 4•6 years ago
|
||
And "edited" comment on BMO, wow, that's new (although I don't see a diff). More to the point: That's a little complicated, so maybe for now we just set the option if we don't need nasm.
|
|
Assignee | |
Comment 5•6 years ago
|
||
I guess you need to put it on your $PATH (I tried moving it to
~/.mozbuild/nasm/nasm.exe but it didn't get auto-detected there).
https://searchfox.org/mozilla-central/rev/23fb3d3791eb9155fb31e76d322d6812cffded90/build/moz.configure/toolchain.configure#96
sounds like it requires you to set NASM in your environment or mozconfig, we should do a better job of picking one up from .mozbuild if it exists.
|
|
Assignee | |
Comment 7•6 years ago
|
||
The attached patch does exactly that.
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Description
•