Closed
Bug 1521583
Opened 6 years ago
Closed 6 years ago
Incorrect vertically centred layout components
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
Details
(Keywords: github-merged)
Attachments
(3 files)
gridgap.png
If you have a single component in the left column and a bunch in the right, and the right is taller then the left, the items in the left get vertically centred.
|
||
Updated•6 years ago
|
Assignee: nobody → sdowne
Iteration: --- → 66.4 - Jan 21 - 27
Priority: -- → P1
|
||
Comment 1•6 years ago
|
||
|
Assignee | |
Comment 2•6 years ago
|
||
Testing instructions.
- Ensure the new tab is the regular version by default.
- In
about:config, changebrowser.newtabpage.activity-stream.discoverystream.configto be{"enabled":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/981a4e3946df5b6a1e7622987007c88a/raw/ee48fa6e8cd6b76e53b29bcdb2deed1d48e199d7/horizontal-center"} - Ensure new tab is rendering something like the screen shot I'm about to attach to this bug.
- Reset the pref, ensure everything is back to normal.
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
||
Comment 4•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/85088466a8225ef2ddbfa4590060c35ca8e4e8a5 Bug 1521583 - vertical alignment of grid. (#4692) * Bug 1521583 - vertical alignment of grid. * Update vertical gap on layouts
|
|
||
Comment 5•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/29bc624b5bb0db7599d977f24fd3a571909b4fda Followup Bug 1521583 - Fix css style regression from grid column alignment and add tests (#4694)
|
||
Updated•6 years ago
|
Keywords: github-merged
|
|
||
Comment 6•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Comment 7•6 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 66.0a1 (2019-01-25)
OS : Mac and Windows 10 Pro
Results attached QA Result : bug - 1521583.png
Closing as verified
|
|
||
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•