On about:support, info is missing for Media, JavaScript, Accessibility, Library Versions, Sandbox and Internationalization & Localization parts
Categories
(Toolkit :: General, defect)
Tracking
()
People
(Reporter: guijoselito, Assigned: jaws)
References
Details
(Keywords: steps-wanted)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
about:support is not complete in today's Nightly.
Info from Media, JavaScript, Accessibility, Library Versions, Sandbox and Internationalization & Localization parts are not there.
In Browser Console there is:
TypeError: Argument 1 of Node.appendChild is not an object.[Learn More] aboutSupport.js:880:25
I'm using WebRender right now, and there are 10 slow frame notifications and 2 failure log, fwiw.
https://bugzilla.mozilla.org/show_bug.cgi?id=1521557 has the same error notification, and I'm pretty sure about:support was working 1 or 2 days ago, at least.
Comment 1•6 years ago
|
||
works for me with a current nightly on windows 10
Updated•6 years ago
|
Reporter | ||
Comment 2•6 years ago
|
||
I think the problem only happens when there's a failure log. Right now it's not working and there is 1 error:
(#0) GP+[GFX1-]: shader-cache: Timed out before finishing loads
Comment 3•6 years ago
|
||
Jared, any idea about this? It looks like you worked recently on this code
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 4•6 years ago
|
||
The failures were remaining in the data object, which later had any remaining keys printed in the diagnostics section. This bug was introduced because we stopped using Array objects to generate formatted strings. In the previous code, this would have ended up just printing out the first failure listed in the diagnostics section (a partial duplicate of the actual Failure Log).
Comment 6•6 years ago
|
||
bugherder |
Comment 7•6 years ago
|
||
Is this something we should consider backporting to Beta?
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
Comment on attachment 9040585 [details]
Bug 1521599 - Delete the failures data after it has been output. r?Gijs
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
Users with graphics failures in their log will get a partial about:support display.
Is this code covered by automated tests?
No
Has the fix been verified in Nightly?
No
Needs manual test from QE?
Yes
If yes, steps to reproduce
List of other uplifts needed
None
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
The fix for this issue is quite simple. Any remaining properties of the graphics
object were being iterated and displayed. The failures
property gets displayed by earlier code but was not deleted afterwards, thus the failures
property was attempted to print again to the Graphics section, though this secondary callsite did not know how to properly display the failures
property. The attached patch deletes the property after it is used the first time thus preventing the issue from occurring.
String changes made/needed
Updated•6 years ago
|
Comment 9•6 years ago
|
||
I have managed to reproduce this issue on an affected Firefox 66.0a1 (20190121175139) build using Windows 10x64 by changing the "gfx.webrender.all" from about:config to true.
This issue is verified fixed using Firefox 67.0a1 (20190211092917) on Windows 10 x64.
Comment on attachment 9040585 [details]
Bug 1521599 - Delete the failures data after it has been output. r?Gijs
Verified in nightly, OK for beta uplift.
Comment 11•6 years ago
|
||
bugherder uplift |
Comment 12•6 years ago
|
||
This is verified fixed on Firefox 66.0b7 too, using Windows 10 x64.
Updated•6 years ago
|
Description
•