Closed
Bug 1521605
Opened 6 years ago
Closed 6 years ago
2/3 width Hero has text and image in reverse order to the spec
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: tspurway, Assigned: gsuntop)
References
Details
(Keywords: github-merged)
Attachments
(3 files)
Hero
In the spec (https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-Home-Modules?node-id=9%3A15) the order is text, then image from left to right. This is reversed in the implementation (see attached).
|
Reporter | |
Updated•6 years ago
|
Assignee: nobody → gsuntop
Iteration: --- → 66.4 - Jan 21 - 27
|
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P1
|
||
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Keywords: github-merged
|
|
Reporter | |
Updated•6 years ago
|
status-geckoview66:
--- → fixed
|
||
Comment 2•6 years ago
|
||
This landed in https://github.com/mozilla/activity-stream/commit/69be66451ac3959b5b799832ac5c02fbc6edad16 but did not have the bug number in the commit message.
"setting proper order for hero img and text in 2/3 layout (#4712)"
Exported in bug 1522752 https://hg.mozilla.org/mozilla-central/rev/9d660bf33923
Blocks: 1522752
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
status-geckoview66:
fixed → ---
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
Assignee | |
Comment 4•6 years ago
|
||
- Set
browser.newtabpage.activity-stream.discoverystream.configto{"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"} - View Hero at 2/3 layout and confirm that the order is text on left and image on right. (see attached)
Flags: needinfo?(gsuntop)
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•