Layout changes to support zooming with containerless scrolling
Categories
(Core :: Layout, enhancement, P2)
Tracking
()
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(7 files, 2 obsolete files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
I'm going to use this bug to track the Layout parts of bug 1459312, and use bug 1459312 for the APZ parts.
|
Assignee | |
Comment 1•6 years ago
|
||
Depends on D12604
|
|
Assignee | |
Comment 2•6 years ago
|
||
The clip will go onto the async zoom container layer instead.
Depends on D17168
|
|
Assignee | |
Comment 3•6 years ago
|
||
In containerless mode, the clip is applied after the resolution, so dividing
by the resolution clips content away when zoomed in.
Depends on D17169
|
|
Assignee | |
Comment 4•6 years ago
|
||
Depends on D17170
|
|
Assignee | |
Comment 5•6 years ago
|
||
Depends on D17171
|
|
Assignee | |
Comment 6•6 years ago
|
||
Sigh. Phabricator is being lame and refusing to associate some of the patches with this bug.
|
|
Assignee | |
Comment 7•6 years ago
|
||
MozReview-Commit-ID: 6qkFXhRDFs
|
|
Assignee | |
Comment 8•6 years ago
|
||
Depends on D17174
|
|
Assignee | |
Comment 9•6 years ago
|
||
Depends on D17175
|
|
Assignee | |
Comment 10•6 years ago
|
||
(In reply to Botond Ballo [:botond] from comment #6)
Sigh. Phabricator is being lame and refusing to associate some of the patches with this bug.
Better now, although the patches are still not displayed in order in the "Phabricator Requests" widget (but they are in the "Stack" view in Phabricator).
Anyways, assuming you're looking at the correct order in the "Stack" view in Phabricator:
- The first two patches were written by Markus; I flagged Matt for review.
- The third patch was written by Markus and revised by me; I flagged Markus and Matt for review.
- The remaining patches were written by me; I flagged Markus or Matt for review as I thought appropriate.
|
|
Assignee | |
Comment 11•6 years ago
|
||
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 12•6 years ago
|
||
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 13•6 years ago
|
||
Depends on D17175
|
||
Comment 14•6 years ago
|
||
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1da2f61f8c53 Add a layer property that indicates async zoom container layers. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/eca791db8967 Create nsDisplayAsyncZoom which creates a ContainerLayer that is marked as an async zoom container. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/509edb594bdb Factor out a helper function to serialize a display list collection into a display list. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/edb058a84ce4 Wrap the root scroll frame contents into an nsDisplayAsyncZoom when using APZ zooming and containerless scrolling. r=mstange,mattwoodrow https://hg.mozilla.org/integration/autoland/rev/352baaa37697 Trigger a full display list rebuild when transition to or from using an async zoom container. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/50ed1bfe7f5a Do not place the RCD-RSF scroll clip onto the layers with RCD-RSF scroll metadata in containerless mode. r=mstange https://hg.mozilla.org/integration/autoland/rev/998c765c5a96 In containerless mode, move handling of pres shell resolution from nsDisplayResolution to nsDisplayAsyncZoom. r=mstange
|
||
Comment 15•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1da2f61f8c53
https://hg.mozilla.org/mozilla-central/rev/eca791db8967
https://hg.mozilla.org/mozilla-central/rev/509edb594bdb
https://hg.mozilla.org/mozilla-central/rev/edb058a84ce4
https://hg.mozilla.org/mozilla-central/rev/352baaa37697
https://hg.mozilla.org/mozilla-central/rev/50ed1bfe7f5a
https://hg.mozilla.org/mozilla-central/rev/998c765c5a96
|
||
Updated•6 years ago
|
|
||
Comment 16•5 years ago
|
||
Hi,
Is there anything in particular that we should test here manually, that is not already covered by our general content scrolling and zooming test suite?
|
|
Assignee | |
Comment 17•5 years ago
|
||
As this bug is part of the containerless scrolling work, I don't think anything beyond the containerless scrolling test plan is needed. Thanks for checking!
Description
•